[Pkg-acpi-devel] Bug#521512: acpid (using netlink) triggers a warning from the kernel

[Darren Salt]

Package: acpid
Version: 1.0.8-6
Tags: patch

I've been seeing the following warning in kernel logs lately:

evdev.c(EVIOCGBIT): Suspicious buffer size 511, limiting output to 64 bytes.
See http://userweb.kernel.org/~dtor/eviocgbit-bug.html

It corresponds with acpid being started up in netlink mode.
The following patch stops acpid from triggering this warning.

--- acpid-1.0.8/debian/patches/netlink.diff	2009-03-27 23:22:10.000000000 +0000
+++ debian/patches/netlink.diff	2009-03-27 23:39:23.000000000 +0000
@@ -1320,7 +1320,7 @@
 +
 +	memset(bit, 0, sizeof(bit));
 +	/* get the event type bitmap */
-+	ioctl(fd, EVIOCGBIT(0, EV_MAX), bit[0]);
++	ioctl(fd, EVIOCGBIT(0, sizeof (bit[0])), bit[0]);
 +
 +	/* for each event type */
 +	for (type = 0; type < EV_MAX; type++) {
@@ -1329,7 +1329,7 @@
 +			/* skip sync */
 +			if (type == EV_SYN) continue;
 +			/* get the event code mask */
-+			ioctl(fd, EVIOCGBIT(type, KEY_MAX), bit[type]);
++			ioctl(fd, EVIOCGBIT(type, sizeof (bit[type])), bit[type]);
 +			/* for each event code */
 +			for (code = 0; code < KEY_MAX; code++) {
 +				/* if this event code is supported */

-- 
| Darren Salt    | linux or ds at              | nr. Ashington, | Toon
| RISC OS, Linux | youmustbejoking,demon,co,uk | Northumberland | Army
|   <URL:http://www.youmustbejoking.demon.co.uk/> (PGP 2.6, GPG keys)

Lost: one mind. Generous reward for the finder.