[Pkg-acpi-devel] Bug#593376: acpi-support: use the shell (buitins), Luke :)
cristian.ionescu-idbohrn at axis.com
Tue Aug 17 17:44:17 UTC 2010
Posixfication and speed: some ideas in the attached patch.
Lots of scripts do things in an inefficient way, and should benefit from
Take, for example, the latest addition which closes bug #589625. Think
lower performant CPU:s (like laptops, netbooks, embedded and others).
The attached (somewhat annotated) patch is a PoC that saves a few CPU
Do not fork and use pipes if there's a perfect builtin for the job.
Do not go rounds testing on '$?' if it can be done in one go.
'read' compared to 'cat' is some 30x more efficient. Specially fitted for
1 line files.
Lots of other scripts would benefit from similar treatment.
-- System Information:
Debian Release: squeeze/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing')
Architecture: i386 (i686)
Kernel: Linux 2.6.32-5-686 (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/bash
Versions of packages acpi-support depends on:
ii acpi-fakekey 0.137-4 tool to generate fake key events
ii acpi-support-base 0.137-4 scripts for handling base ACPI eve
ii acpid 1:2.0.6-1 Advanced Configuration and Power I
ii lsb-base 3.2-23.1 Linux Standard Base 3.2 init scrip
ii pm-utils 1.3.0-2 utilities and scripts for power ma
ii x11-xserver-utils 7.5+2 X server utilities
Versions of packages acpi-support recommends:
ii dbus 1.2.24-3 simple interprocess messaging syst
pn radeontool <none> (no description available)
ii vbetool 1.1-2 run real-mode video BIOS code to a
pn xscreensaver | gnome-screensa <none> (no description available)
Versions of packages acpi-support suggests:
ii rfkill 0.4-1 tool for enabling and disabling wi
ii xinput 1.5.2-1 Runtime configuration and test of
-- no debconf information
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 2447 bytes
More information about the Pkg-acpi-devel