[Pkg-acpi-devel] Bug#603864: Bug#603864: acpi-support-base: latest revision; some small improvements

Cristian Ionescu-Idbohrn cristian.ionescu-idbohrn at axis.com
Thu Nov 18 12:25:18 UTC 2010


On Thu, 18 Nov 2010, Michael Meskes wrote:
> On Thu, Nov 18, 2010 at 12:19:16AM +0100, Cristian Ionescu-Idbohrn wrote:
> >   		return 1;
> > +***		        ^
> > +***			not needed
>
> Is there any non-optical advantage of patching this?

Yes.  It takes a few more electrons to parse both control operator ';'
and control operator 'newline', for no good reason.

> I don't like adding patches to "only" remove superfluous stuff that
> doesn't hurt.

Your decision.

> Also in your patch you replace test with [ ], is there any technical
> reason for this?

No, no technical reason, though makes it considerably easier to read,
IMO.


Cheers,

-- 
Cristian





More information about the Pkg-acpi-devel mailing list