[Pkg-acpi-devel] Bug#604251: acpi-support-base: attempt to robustify power-funcs

[Cristian Ionescu-Idbohrn]

Package: acpi-support-base
Version: 0.137-7
Severity: normal
Tags: patch

A small part of this patch touches the same area as bug#603796.
Added annotations in various areas that need reviewing.

Motivation:

* performance improvements: uses more shell builtins instead of forking
  (yes, it's more code but it runs faster)
* error handling improvements: reports errors to the system log in an
  attempt to make trouble shooting easier (surprisingly many commands were
  simply ignoring errors)
* attempts to correct a sed regex greedyness problem

Yes, I tested the changes on a desktop and a norebook.  Shell used was
dash, with options '-e' and '-u'.

It is not easy to distinguish between function local variables and global
variables.  A naming convention does not seem to exist either.  A proper
cleanup would be needed too, to improve readability.


-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing')
Architecture: i386 (i686)

Kernel: Linux 2.6.32-5-686 (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/bash

Versions of packages acpi-support-base depends on:
ii  acpid                      1:2.0.7-1     Advanced Configuration and Power I
ii  console-tools [console-uti 1:0.2.3dbs-69 Linux console and font utilities

acpi-support-base recommends no packages.

Versions of packages acpi-support-base suggests:
ii  acpi-support                  0.137-7    scripts for handling many ACPI eve

-- no debconf information

Cheers,

-- 
Cristian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: power-funcs.1.patch
Type: text/x-diff
Size: 5955 bytes
Desc: 
URL: <http://lists.alioth.debian.org/pipermail/pkg-acpi-devel/attachments/20101121/23f31ec5/attachment.patch>