[Pkg-acpi-devel] Bug#665987: Bug#665987: acpi-supoort: Please make consolekit optional

[Guillem Jover]

reopen 665987
thanks

Hi!

On Wed, 2012-03-28 at 17:26:06 +0200, Michael Meskes wrote:
> On Wed, Mar 28, 2012 at 04:45:06PM +0200, Guillem Jover wrote:
> > From this reply it's not really clear why, so maybe the attached patch
> > can change your mind? consolekit it not usable anyway with things like

> Well, you didn't give any reason for why it should be demoted so I didn't
> feel like giving one either. :)

Sorry, I assumed that given that it was not being used before, and it
started to get used now, the possibility to demote it was not outrageous,
or if it was you'd be aware of it right away.

Also consolekit upstream is not even maintained anymore and it's
considered deprecated (which seems like a trend with all that
plumbing *kit stuff)...

> > startx or when the system is not running an X session, for example.
> 
> Now that is a serious problem IMO and definitely needs attention. Upstream
> changed to ck-list-sessions because it seems to be the only tool working with
> lightdm: https://bugs.launchpad.net/ubuntu/+source/acpi-support/+bug/933626

> > ++if which ck-list-sessions >/dev/null; then
> > ++	LISTSESSIONS=ck-list-sessions
> > ++else
> > ++	LISTSESSIONS=:
> > ++fi
> 
> This won't work well I think. But how about falling back to the old way of
> using pinky if ck-list-sessions is not available?

Well for the cases I listed above, ck-list-session will just not return
anything, so calling it or not calling it has the same effect. Not
calling it if it's not available has the advantage of not requiring it
at run-time and making it an optional dependency, like a Recommends.

On Sun, 2012-04-01 at 12:35:03 +0200, Michael Meskes wrote:
> On Wed, Mar 28, 2012 at 04:45:06PM +0200, Guillem Jover wrote:
> > can change your mind? consolekit it not usable anyway with things like
> > startx or when the system is not running an X session, for example.
>·
> I just tried getXuser() and getXconsole() from acpi-support's power-funcs and
> both work without any problem if the X session was started with startx. There
> is is special logic in there to cope with this case. Also I don't really
> understand what you mean with "when the system is not running an X session".
> What does not work then? I thought you were talking about some acpi-support
> failures but cannot find any, so please give details. It does not matter
> whether or not consolekit works then because it is only used to find the X
> user.

Exactly, and that's precisely why consolekit is in principle optional,
because the code will fallback to something else, but that requires
consolekit to not be required.

When I referred to “when the system is not running an X session” I
meant when the system does not have any X server running, and it's
just running on the system console.

In addition Recommends are installed by default, so that should cover
the majority of the users, but allow others to choose not to install
those if they so desire.

thanks,
guillem