[Pkg-acpi-devel] Bug#755888: Bug#755888: acpi-support-base: does alarming things with su and dbus-send

[Michael Meskes]

On Thu, Jul 24, 2014 at 11:15:44AM +0100, Simon McVittie wrote:
> * Probe for HasLogindAndSystemd1Manager first, before even looking
>   for the X11 user. This check can be done at a purely system-wide level,
>   without involving yourself with individual users. Also, systemd-logind
>   is meant to be installed by default in Debian 8, and is increasingly
>   depended-on by desktop environments anyway, so this check will often
>   succeed, short-circuiting the scarier logic.

I don't really understand, the HasLogindAndSystemd1Manager test runs before the
DBUS based tests, doesn't it?

> * Consider checking only for the presence of systemd-logind, not
>   for its ability to shut down. That would be significantly simpler,
>   and in the unlikely event that systemd-logind is running but the sysadmin
>   has explicitly configured it to not do power management, it seems
>   undesirable for acpi-support to jump in and do it instead.
>
> * Modern GNOME relies on systemd-logind for suspend/hibernate/shutdown,
>   so don't dbus-send to it, and perhaps don't check for its processes
>   either; either systemd-logind will do the job, or GNOME won't.
>   Also, as with systemd-logind, in the unlikely event that the logged-in
>   user has explicitly configured GNOME to not load the Power plugin,
>   it seems undesirable for acpi-support to jump in and do it.

I don't like making that assumption. You can easily see case where people use
different GUIs from time to time but want the system to always react the same
way and thus prefer to have acpi-support handle things.

> * I believe modern KDE relies on systemd-logind too; I don't use it,
>   but the KDE maintainers would know.

The last time I checked it didn't but that has been a while. 
 
> * KDE no longer appears to have dcop, so avoid "/usr/bin/dcop --user $XUSER";
>   if you want to support obsolete KDE, avoid that anyway, unless dcop has
>   been audited and is specifically safe for root to use like this.

Right, removed.

Michael

-- 
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL