[Pkg-alsa-devel] Bug#269494: marked as done (/etc/init.d/alsa: force-stop fails on disappeared process)
Debian Bug Tracking System
owner@bugs.debian.org
Wed, 22 Sep 2004 08:03:24 -0700
Your message dated Wed, 22 Sep 2004 10:47:06 -0400
with message-id <E1CA8Og-0006EV-00@newraff.debian.org>
and subject line Bug#269494: fixed in alsa-driver 1.0.6a-1
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 1 Sep 2004 19:37:52 +0000
>From jdthood@yahoo.co.uk Wed Sep 01 12:37:52 2004
Return-path: <jdthood@yahoo.co.uk>
Received: from post-22.mail.nl.demon.net [194.159.73.192]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1C2avY-0004Co-00; Wed, 01 Sep 2004 12:37:52 -0700
Received: from aglu.demon.nl ([82.161.38.140]:63653 helo=localhost)
by post-22.mail.nl.demon.net with esmtp (Exim 4.34)
id 1C2aru-000Fyl-Q9; Wed, 01 Sep 2004 19:37:51 +0000
Received: by localhost (Postfix, from userid 1001)
id 38E4910D6D1; Wed, 1 Sep 2004 21:34:31 +0200 (CEST)
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Thomas Hood <jdthood@yahoo.co.uk>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: /etc/init.d/alsa: force-stop fails on disappeared process
X-Mailer: reportbug 2.64
Date: Wed, 01 Sep 2004 21:34:30 +0200
Message-Id: <20040901193431.38E4910D6D1@localhost>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
Package: alsa-base
Version: 1.0.5a-3
Severity: important
Tags: patch
The initscript exits in the force-stop method if the kill command fails
because it is trying to kill a process that is already dead. (The
script runs with the -e option.) Here is a patch that fixes this problem
and also improves the effort at sound process genocide.
--- alsa_ORIG 2004-08-23 13:46:22.000000000 +0200
+++ alsa 2004-09-01 21:01:06.000000000 +0200
@@ -42,12 +42,18 @@
fi
;;
force-stop|force-reload)
- procs_using_sound="$(lsof +D /dev -F rt | awk '/^p/ {pid=$1} /^t/ {type=$1} /^r0x(74|e)..$/ && type == "tCHR" {print pid}' | cut -c 2- | uniq)"
+ set_procs_using_sound() {
+ procs_using_sound="$(lsof +D /dev -F rt | awk '/^p/ {pid=$1} /^t/ {type=$1} /^r0x(74|e)..$/ && type == "tCHR" {print pid}' | cut -c 2- | uniq)"
+ }
+ set_procs_using_sound
if [ ! -z "$procs_using_sound" ]; then
printf "Terminating processes ... "
- kill $procs_using_sound
+ kill $procs_using_sound || :
sleep 2
- kill -9 $procs_using_sound
+ set_procs_using_sound
+ if [ ! -z "$procs_using_sound" ]; then
+ kill -9 $procs_using_sound || :
+ fi
echo "done"
fi
$0 stop
-- System Information:
Debian Release: 3.1
APT prefers testing
APT policy: (500, 'testing'), (50, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.8.1
Locale: LANG=en_IE@euro, LC_CTYPE=en_IE@euro
Versions of packages alsa-base depends on:
ii alsa-utils 1.0.5-3 Advanced Linux Sound Architecture
ii debconf 1.4.32 Debian configuration management sy
ii debianutils 2.8.4 Miscellaneous utilities specific t
ii module-init-tools 3.1-pre5-6 tools for managing Linux kernel mo
ii modutils 2.4.26-1 Linux module utilities
ii psmisc 21.5-1 Utilities that use the proc filesy
-- debconf information:
* alsa-base/alsactl_store_on_shutdown: never autosave
---------------------------------------
Received: (at 269494-close) by bugs.debian.org; 22 Sep 2004 14:53:39 +0000
>From katie@ftp-master.debian.org Wed Sep 22 07:53:39 2004
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1CA8V1-0007Ct-00; Wed, 22 Sep 2004 07:53:39 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
id 1CA8Og-0006EV-00; Wed, 22 Sep 2004 10:47:06 -0400
From: Jordi Mallach <jordi@debian.org>
To: 269494-close@bugs.debian.org
X-Katie: $Revision: 1.51 $
Subject: Bug#269494: fixed in alsa-driver 1.0.6a-1
Message-Id: <E1CA8Og-0006EV-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Wed, 22 Sep 2004 10:47:06 -0400
Delivered-To: 269494-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
X-CrossAssassin-Score: 13
Source: alsa-driver
Source-Version: 1.0.6a-1
We believe that the bug you reported is fixed in the latest version of
alsa-driver, which is due to be installed in the Debian FTP archive:
alsa-base_1.0.6a-1_all.deb
to pool/main/a/alsa-driver/alsa-base_1.0.6a-1_all.deb
alsa-driver_1.0.6a-1.diff.gz
to pool/main/a/alsa-driver/alsa-driver_1.0.6a-1.diff.gz
alsa-driver_1.0.6a-1.dsc
to pool/main/a/alsa-driver/alsa-driver_1.0.6a-1.dsc
alsa-driver_1.0.6a.orig.tar.gz
to pool/main/a/alsa-driver/alsa-driver_1.0.6a.orig.tar.gz
alsa-headers_1.0.6a-1_all.deb
to pool/main/a/alsa-driver/alsa-headers_1.0.6a-1_all.deb
alsa-source_1.0.6a-1_all.deb
to pool/main/a/alsa-driver/alsa-source_1.0.6a-1_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 269494@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Jordi Mallach <jordi@debian.org> (supplier of updated alsa-driver package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Wed, 22 Sep 2004 14:45:19 +0200
Source: alsa-driver
Binary: alsa-source alsa-headers alsa-base
Architecture: source all
Version: 1.0.6a-1
Distribution: unstable
Urgency: medium
Maintainer: Debian ALSA Maintainers <pkg-alsa-devel@lists.alioth.debian.org>
Changed-By: Jordi Mallach <jordi@debian.org>
Description:
alsa-base - ALSA sound driver common files
alsa-headers - ALSA sound driver header files
alsa-source - ALSA sound driver source
Closes: 188595 249505 261924 267939 268041 268480 269196 269211 269212 269214 269282 269453 269494 270316 270419 272510
Changes:
alsa-driver (1.0.6a-1) unstable; urgency=medium
.
* New upstream release.
* Steve Kowalik:
- Fix up patches #4, #9, #10 and #15 to apply cleanly.
- Rename 'autosave always' to 'always autosave'. Both settings will be
honoured. (Closes: #269196)
- Change the default value of alsactl_store_on_shutdown to
'always autosave'. Also rewrite the comment to list the 3 settings,
and what the 3 settings do. Also change the postinst to only run
alsactl store if the value is 'always autosave'. (Closes: #269214)
- Honour changes made to /etc/default/alsa in alsa-base's config
script. (Closes: #261924, #268041)
- Stop using /var/lib/alsa-base in alsa-modules, and don't create the
directory in alsa-base. (Closes: #269211)
- Include a bunch of new cards in alsa-source's debconf prompting:
+ atiixp-modem: PCI: ATI IXP 150/200/250 Modem
+ cs46xx-new-dsp: Cirrus Logic (Sound Fusion) New DSP support
+ emu10k1x: PCI: EMU10K1 (SB Live! or E-mu APS, Dell OEM Version)
+ fm801-tea575x: PCI: ForteMedia FM801 + TEA5757 tuner
+ seq-dummy: Sequencer dummy client
+ sun-amd7930: SPARC: Sun AMD7930
+ sun-cs4231: SPARC: Sun CS4231
+ (Closes: #249505)
- Update French Debconf translation. (Closes: #267939)
(thanks, Christian Perrier)
- Update Spanish Debconf translation. (Closes: #268480)
(thanks, Carlos Galisteo)
* Jordi Mallach:
- Update Catalan Debconf translation.
- Don't try to install alsa-modules.dirs which is now gone.
- Update debian/patches/10_disable_gcc_version_check2.dpatch.
* Thomas Hood:
- /etc/init.d/alsa: Extensive changes
+ Clean up indentation
+ Don't fail if kill fails because of disappeared process
(Closes: #269494)
+ Tell the user if processes couldn't be stopped or if
modules couldn't be unloaded (Closes: #269453)
+ Send usage to stderr and exit 3 (as per LSB)
+ Use more functions
+ On restart, attempt start even if stop fails
+ On force-reload, start after force-stop
+ Don't pad '...' with spaces (as per policy 9.4)
+ On start, don't fail if attempt to restore mixer levels fails.
In order to avoid lost races this should be done by the module
loader (see #268221). (Closes: #270419)
- /etc/default/alsa
+ Try to improve comments some more
- /etc/apm/event.d/alsa
+ Rewrite
+ Remove redundant fuser commands. Calling the initscript with
"force-stop" should do everything that is required.
(Closes: #269282)
- alsa-base.postinst
+ Clean up
+ Run confmodule at the beginning since it restarts the script
+ Eliminate use of test's -a and -o options
+ exit 1 on illegal argument
+ Use '.dpkg-old' as backup-file extension
+ Only initialize asound.state if it doesn't already
exits (Closes: #188595)
+ Update from debconf database even if conf file is
initialized from /usr/share/alsa-base/alsa-base.conf
(Closes: #269212)
+ Use cat instead of cp in order to handle the case
where people have replaced conf files by symlinks
+ Always use -f option with mv and rm
+ Replace 'autosave always' by 'always autosave'
- debian/control:
+ Make alsa-base Depend on alsa-utils >= 1.0.6-1
- debian/po/nl.po:
+ Update, thanks to cobaco (Closes: #270316)
- debian/po/da.po:
+ Update, thanks to Morten Brix Pedersen (Closes: #272510)
- debian/po/*:
+ Replace 'autosave always' by 'always autosave'
+ Fix typos, run debconf-updatepo
Files:
23250a2b42a6f0115fda1a4d384a12df 844 sound optional alsa-driver_1.0.6a-1.dsc
36fcbbf18148093508e4386d4b932dc4 2294487 sound optional alsa-driver_1.0.6a.orig.tar.gz
e604a53b2aa5e4a181e5d527fe23e5db 93199 sound optional alsa-driver_1.0.6a-1.diff.gz
901cd0e0e4fee469ebb23f101b2a9736 49498 sound optional alsa-base_1.0.6a-1_all.deb
01a9add52780456887e784964685cb25 1855674 sound optional alsa-source_1.0.6a-1_all.deb
0c02716d94405b14212b5b62f30fe782 58022 sound optional alsa-headers_1.0.6a-1_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
iD8DBQFBUW20JYSUupF6Il4RApnUAJ9TFTh4GTYUPUhN2L+AEvptebML5wCfdF99
TiY8SG4SahB9BHgRG5lflw8=
=T4xt
-----END PGP SIGNATURE-----