[Pkg-alsa-devel] Bug#953568: alsa-lib FTFS in testing.

[peter green]

Package: alsa-lib
Version: 1.2.2-2.1
Severity: serious
Tags: bullseye, patch

I just ran into the following build failure in raspbian bullseye, checking on reproducible builds confirmed that the failure is not raspbian specific.

http://buildd.raspbian.org/status/fetch.php?pkg=alsa-lib&arch=armhf&ver=1.2.2-2.1&stamp=1583817597
https://tests.reproducible-builds.org/debian/rb-pkg/bullseye/amd64/alsa-lib.html

> /bin/bash ../../../libtool  --tag=CC   --mode=link gcc -I/usr/include/python3.7m -I/usr/include/python3.7m -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -module -avoid-version -Wl,-z,defs -Wl,-z,relro -Wl,-z,now -o smixer-python.la -rpath /usr/lib/arm-linux-gnueabihf/alsa-lib/smixer smixer_python_la-python.lo ../../../src/libasound.la Usage: /usr/bin/python3-config --prefix|--exec-prefix|--includes|--libs|--cflags|--ldflags|--extension-suffix|--help|--abiflags|--configdir
> /bin/bash: --exec-prefix: command not found
> /bin/bash: --includes: command not found
> /bin/bash: --cflags: command not found
> /bin/bash: --libs: command not found
> /bin/bash: --extension-suffix: command not found
> /bin/bash: --ldflags: command not found
> /bin/bash: --help: command not found
> /bin/bash: --configdir: command not found
> /bin/bash: --abiflags: command not found
> make[4]: *** [Makefile:474: smixer-python.la] Error 127
The python 3.8 patch is to blame and is breaking builds with 3.7 (still the default in testing). I whipped up the attached debdiff and was able to get successful builds in raspbian bullseye and debian sid armhf.

While I was working on this I also discovered the clean target was not cleaning up properly, so I fixed that too.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-alsa-devel/attachments/20200310/853da4a8/attachment.html>
-------------- next part --------------
diff -Nru alsa-lib-1.2.2/debian/changelog alsa-lib-1.2.2/debian/changelog
--- alsa-lib-1.2.2/debian/changelog	2020-03-07 18:21:22.000000000 +0000
+++ alsa-lib-1.2.2/debian/changelog	2020-03-10 15:12:02.000000000 +0000
@@ -1,3 +1,10 @@
+alsa-lib (1.2.2-2.1+rpi1) bullseye-staging; urgency=medium
+
+  * Modify python 3.8 patch so builds with 3.7 still work.
+  * Fix clean target.
+
+ -- Peter Michael Green <plugwash at raspbian.org>  Tue, 10 Mar 2020 15:12:02 +0000
+
 alsa-lib (1.2.2-2.1) unstable; urgency=medium
 
   [ Matthias Klose ]
diff -Nru alsa-lib-1.2.2/debian/patches/python3.8.diff alsa-lib-1.2.2/debian/patches/python3.8.diff
--- alsa-lib-1.2.2/debian/patches/python3.8.diff	2020-03-04 08:23:20.000000000 +0000
+++ alsa-lib-1.2.2/debian/patches/python3.8.diff	2020-03-10 15:12:02.000000000 +0000
@@ -10,7 +10,7 @@
    pythoninc0=
    if test "$build_python2" != "yes"; then
 -    pythonlibs0=$(python3-config --libs)
-+    pythonlibs0=$(python3-config --libs --embed)
++    pythonlibs0=$(python3-config --libs `python3 -c 'import sys;print("" if sys.version_info < (3,8) else "--embed")'`)
      pythoninc0=$(python3-config --includes)
    fi
    if test -z "$pythonlibs0"; then
diff -Nru alsa-lib-1.2.2/debian/rules alsa-lib-1.2.2/debian/rules
--- alsa-lib-1.2.2/debian/rules	2020-02-29 15:51:16.000000000 +0000
+++ alsa-lib-1.2.2/debian/rules	2020-03-10 15:12:02.000000000 +0000
@@ -38,3 +38,8 @@
 
 override_dh_makeshlibs:
 	dh_makeshlibs -- -c4
+
+override_dh_auto_clean:
+	rm -rf doc/doxygen
+	rm -f src/control/ctl_symbols_list.c src/control/libcontrol.la src/hwdep/libhwdep.la src/mixer/libmixer.la src/pcm/libpcm.la src/pcm/pcm_symbols_list.c src/rawmidi/librawmidi.la src/seq/libseq.la src/timer/libtimer.la src/ucm/libucm.la
+	dh_auto_clean