[Pkg-alsa-devel] Bug#1093057: alsa-utils: udev/rules.d/90-alsa-restore.rules:16 GOTO="alsa_restore_std" has no matching label, ignoring

[Uwe Kleine-König]

Control: tag -1 - fixed-upstream
Control: force-merge -1 1108340
Control: notforwarded -1 
Control: found -1 1.2.14-1
Control: notfound -1 1.2.13-1

Hello,

On Wed, Jan 15, 2025 at 08:17:00AM +0900, Ryutaroh Matsumoto wrote:
> Package: alsa-utils
> Version: 1.2.13-1
> Severity: minor
> Tags: fixed-upstream
> 
> Dear Maintainer,
> 
> When I boot RaspberryPi 4B (genuin Debian distribution), I always see
> Jan 13 01:56:19 raspi4b-router2 systemd-udevd[450]: /usr/lib/udev/rules.d/90-alsa-restore.rules:16 GOTO="alsa_restore_std" has no matching label, ignoring.
> Jan 13 01:56:19 raspi4b-router2 systemd-udevd[450]: /usr/lib/udev/rules.d/90-alsa-restore.rules:16 The line has no effect any more, dropping.
> Jan 13 01:56:19 raspi4b-router2 systemd-udevd[450]: /usr/lib/udev/rules.d/90-alsa-restore.rules:20 GOTO="alsa_restore_std" has no matching label, ignoring.
> Jan 13 01:56:19 raspi4b-router2 systemd-udevd[450]: /usr/lib/udev/rules.d/90-alsa-restore.rules:20 The line has no effect any more, dropping.
> 
> This bug, nonexistence of alsa_restore_std, has been fixed in upstream, as
> https://github.com/alsa-project/alsa-utils/blob/54e09df6bc3c321879c15ae6d22dfe0db669c5a7/alsactl/90-alsa-restore.rules.in#L26-L28

In the meantime the bug evolved and became a Debian-specific bug.
Updated the bug's metadata accordingly. There is alsa-utils 1.2.14-1 in
trixie, which contains the upstream fix (i.e.

	https://github.com/alsa-project/alsa-utils/commit/f90124c73edd050b24961197a4abcf17e53b41a8

) that originally fixed this issue, but refreshing patches after that
change went wrong in

	https://salsa.debian.org/alsa-team/alsa-utils/-/commit/5634db8d43db68742374e7945977b6debf428ca5

. The fix looks as follows:

diff --git a/debian/patches/alsactl_home.patch b/debian/patches/alsactl_home.patch
index 0fca221002c7..5065282d722f 100644
--- a/debian/patches/alsactl_home.patch
+++ b/debian/patches/alsactl_home.patch
@@ -63,10 +63,9 @@ Index: alsa-utils/alsactl/90-alsa-restore.rules.in
  IMPORT{program}="/usr/bin/cat /run/udev/alsa-hda-analog-card"
  ENV{ALSA_CARD_HDA_ANALOG}!="", ENV{ALSA_CARD_NUMBER}="$env{ALSA_CARD_HDA_ANALOG}"
  
--LABEL="alsa_restore_std"
+ LABEL="alsa_restore_std"
 -TEST!="@daemonswitch@", RUN+="@sbindir@/alsactl at args@ restore $env{ALSA_CARD_NUMBER}"
 -TEST=="@daemonswitch@", RUN+="@sbindir@/alsactl at args@ nrestore $env{ALSA_CARD_NUMBER}"
-+LABEL="alsa_restore_go"
 +TEST!="@daemonswitch@", RUN+="@sbindir@/alsactl at args@ -E HOME=@alsactlhome@ restore $env{ALSA_CARD_NUMBER}"
 +TEST=="@daemonswitch@", RUN+="@sbindir@/alsactl at args@ -E HOME=@alsactlhome@ nrestore $env{ALSA_CARD_NUMBER}"
 

Best regards
Uwe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-alsa-devel/attachments/20250626/d8d3a719/attachment-0003.sig>