[pkg-apparmor] [PATCH 5/6] Include tunables/global in gst_plugin_scanner profile.

Felix Geyer fgeyer at debian.org
Sat Aug 30 19:17:34 UTC 2014


On 30.08.2014 20:55, intrigeri wrote:
> Felix Geyer wrote (29 Aug 2014 21:19:24 GMT) :
>> ---
>>  profiles/gst_plugin_scanner | 2 ++
>>  1 file changed, 2 insertions(+)
> 
> I've pondered doing this 2 days ago.
> 
> On the one hand, this prevents a warning from being displayed at
> policy compile time. On the other hand, this named profile is only
> supposed to be transitioned to explicitly from other profiles that
> must anyway include tunables/global, so strictly speaking we don't
> really need to do it again here.

You really do need tunables/global.

It is a profile in the global namespace. abstractions/totem doesn't
include gst_plugin_scanner.

> I'm tempted to just take your patch, but I'd like to hear what other
> people think of it. The best way to do that would be to submit a merge
> request against the apparmor-profiles repo, implementing this
> change... which IMO is a "must do" anyway before we take it into
> aa-p-extra, since I'd rather not see us maintaining delta when it can
> easily be avoided.

Agreed, but I think there is some more cleanup needed.
Shouldn't the "Cix -> gst_plugin_scanner," line be part of the gstreamer
abstraction?

Cheers,
Felix



More information about the pkg-apparmor-team mailing list