[pkg-apparmor] Review of "How to contribute to the AppArmor upstream profiles"

[intrigeri]

Hi,

here's a review of
https://apparmor.451f.org/2014/12/23/how-to-contribute-to-the-apparmor-upstream-profiles/

> contribute to existing/upstream AppArmor profiles

Linking from there to
https://code.launchpad.net/~apparmor-dev/apparmor-profiles/ suggests
that it's the one and only place where upstream profiles are
developed. As you know, this is not correct: that repo is a staging
area for WIP profiles, as opposed to the ones shipped in the AppArmor
released tarballs.

Of course, this piece of doc is probably not the best place to go
through all these subtleties, and it's better to keep it simple and
focus on one single example as you did. So, maybe we could add
a sentence at the end of the blog post, e.g. "Note that upstream
AppArmor profiles also live in other repositories", with "in other
repositories" linking to the place where you've documented all
the details?

> upload an SSH key

s/an/a/

> ask for a merge and pull into the master branch

"merge and pull" feels redundant, and possibly confusing as there's
only one thing to ask, really. "merge" would be enough.

I believe one has to commit between "start modifying the profiles" and
"you can push the changes". Or is bzr doing it automatically
when pushing?

> bzr push

Is that really enough to push to the right place on Launchpad? I guess
not, since the next step is to manually "link the branch to
apparmor-profiles", which is not necessary if one pushes to the right
place initially, that is something like
lp:~myname/apparmor-profiles/pidgin.

> to do a merge request

"to request a merge"?

Good job!

Cheers,
-- 
intrigeri