[pkg-apparmor] Bug#880859: apparmor-notify: packaging patches first utils/notify.conf but then overwrites it with debian/notify/notify.conf

Salvatore Bonaccorso carnil at debian.org
Sun Nov 5 07:57:50 UTC 2017


Package: apparmor-notify
Version: 2.11.1-2
Severity: normal

Hi

While looking at apparmor-notify I noticed that in the source package
we first patch utils/notify.conf to set use_group="adm" (from the
original "admin"). This was actually handled a couple of yerars back
in #660078). But then we install a custom debian/notify/notify.conf
setting the group to "sudo".

In the changelog I found:

apparmor (2.8.95~2430-0ubuntu3) trusty; urgency=medium
[...]
  * debian/notify/notify.conf: use_group should be set to "sudo" instead of
    "admin" (LP: #1009666)
[...]
apparmor (2.7.103-1) unstable; urgency=low
[...]
  * debian/patches/notify-group.patch, debian/apparmor-notify.install,
    debian/notify/notify.conf: Remove custom notify.conf file, and modify
    the upstream one instead, adjusting the group to "adm", thanks to
    Intrigeri (Closes: 660078).

Which approach is more sensible for Debian's version?

Or, but not checked the code if 

> or -even better IMHO- it may not set use_group at all, given
>  aa-notify only uses this setting if it is set.

is still true, then just drop setting of use_group?

Regards,
Salvatore



More information about the pkg-apparmor-team mailing list