[pkg-apparmor] Bug#941595: allow logs in ~/.irssi/irclogs

[Antoine Beaupre]

Package: apparmor-profiles-extra
Severity: wishlist
Tags: patch

It's common to store irc logs in ~/.irssi/irclogs. Even though
upstream suggests the default is ~/irclogs, that breaks all sorts of
expectations (like that programs shouldn't store random files in the
home directory).

(Arguably, even ~/.irssi should be in ~/.config, but that's besides
the point.)

This patch fixes the problem for me:

--- /etc/apparmor.d/usr.bin.irssi.dpkg-dist     2019-02-25 09:34:49.000000000 -0500
+++ /etc/apparmor.d/usr.bin.irssi       2017-07-01 14:05:39.211383678 -0400
@@ -41,9 +41,10 @@
   owner @{HOME}/.irssi/*.theme wk,

   # http://www.irssi.org/documentation/startup states that ~/irclogs is the
-  # default location for logs.
-  owner @{HOME}/irclogs/ r,
-  owner @{HOME}/irclogs/** rwk,
+  # default location for logs. Also allow the common configuration of logging
+  # inside the .irssi directory.
+  owner @{HOME}/{.irssi/,}irclogs/ r,
+  owner @{HOME}/{.irssi/,}irclogs/** rwk,

   # for fnotify
   owner @{HOME}/.irssi/fnotify rwk,


-- System Information:
Debian Release: 10.1
  APT prefers stable
  APT policy: (500, 'stable'), (1, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-6-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_CA.UTF-8, LC_CTYPE=fr_CA.UTF-8 (charmap=UTF-8), LANGUAGE=fr_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages apparmor-profiles-extra depends on:
ii  apparmor  2.13.2-10

apparmor-profiles-extra recommends no packages.

apparmor-profiles-extra suggests no packages.