[Pkg-auth-maintainers] Bug#984480: python3-yubikey-manager: copyright file missing after upgrade (policy 12.5)

[Andreas Beckmann]

Package: python3-yubikey-manager
Version: 4.0.0~a1-2
Severity: serious
User: debian-qa at lists.debian.org
Usertags: piuparts

Hi,

a test with piuparts revealed that your package misses the copyright
file after an upgrade, which is a violation of Policy 12.5:
https://www.debian.org/doc/debian-policy/ch-docs.html#copyright-information

After the upgrade /usr/share/doc/$PACKAGE/ is just an empty directory.

This was observed on the following upgrade paths:

  buster -> bullseye

>From the attached log (scroll to the bottom...):

0m36.3s ERROR: WARN: Inadequate results from running adequate!
  python3-yubikey-manager: missing-copyright-file /usr/share/doc/python3-yubikey-manager/copyright

  MISSING COPYRIGHT FILE: /usr/share/doc/python3-yubikey-manager/copyright
  # ls -lad /usr/share/doc/python3-yubikey-manager
  drwxr-xr-x 2 root root 40 Mar  3 01:47 /usr/share/doc/python3-yubikey-manager
  # ls -la /usr/share/doc/python3-yubikey-manager/
  total 0
  drwxr-xr-x   2 root root   40 Mar  3 01:47 .
  drwxr-xr-x 142 root root 2980 Mar  3 01:47 ..


Additional info may be available here:
https://wiki.debian.org/MissingCopyrightFile

Note that dpkg intentionally does not replace directories with symlinks
and vice versa, you need the maintainer scripts to do this.
See in particular the end of point 4 in
https://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#details-of-unpack-phase-of-installation-or-upgrade

It is recommended to use the dpkg-maintscript-helper commands
'dir_to_symlink' and 'symlink_to_dir' (available since dpkg 1.17.14)
to perform the conversion, ideally using d/$PACKAGE.maintscript.
See dpkg-maintscript-helper(1) and dh_installdeb(1) for details.


cheers,

Andreas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: python3-yubikey-manager_4.0.0~a1-2.log.gz
Type: application/gzip
Size: 22958 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-auth-maintainers/attachments/20210304/46add179/attachment-0001.gz>