[Pkg-ayatana-devel] RFS: notify-osd 0.9.32-1 (includes RC bug fix)

[Andrew Starr-Bochicchio]

On Thu, Jan 12, 2012 at 5:19 PM, Andrew Starr-Bochicchio
<a.starr.b at gmail.com> wrote:
> On Wed, Jan 11, 2012 at 5:26 AM, Evgeni Golov <evgeni at debian.org> wrote:
>> Hi,
>>
>> On 01/10/2012 06:54 PM, Andrew Starr-Bochicchio wrote:
>>>>    - Drop Conflict/Replace on notify-daemon and alsdorf.(Closes: #541779).
>>>>    - Add Replaces on notification-daemon.
>>
>> I am not sure about that change. (and neither of the dpkg-divert usage)
>>
>> Replaces means package A may replace files in package B or replaces it
>> completelly [1]. However I do not see how notification-daemon is
>> deprecated is should be replaced fully, neither I see why notify-osd
>> should be allowed to overwrite the service file, basically rendering
>> notification-daemon unused on the system. Isn't that the very cause why
>> we have alternatives selection?
>
> I think you're right. This seems to just be a way to force its use on
> Ubuntu. Though on further investigation, notification-daemon doesn't
> even seem to provide that file.
>
>  $ apt-file search
> /usr/share/dbus-1/services/org.freedesktop.Notifications.service
> notify-osd: /usr/share/dbus-1/services/org.freedesktop.Notifications.service
>
> It seems like we can safely drop the dpkg-divert logic as well as the
> Replaces. I wonder if we should even bother installing the service
> file at all. I don't think that there is a case where it will launch
> notify-osd on a Debian system through that method.

I've pushed a new revision to aloith that doesn't install the dbus
activation file and gets rid of both the Replaces and the diversion.
This seems consistent with the discussion in BTS #640120.

I'd appreciate another review, especially of the preinst script which
cleans up the old diversion.

You can grab it from:

dget http://mentors.debian.net/debian/pool/main/n/notify-osd/notify-osd_0.9.32-1.dsc

Or:

bzr branch bzr+ssh://bzr.debian.org/bzr/pkg-ayatana/notify-osd/debian/

Thanks!

-- Andrew Starr-Bochicchio

   Ubuntu Developer <https://launchpad.net/~andrewsomething>
   Debian Maintainer
<http://qa.debian.org/developer.php?login=a.starr.b%40gmail.com>
   PGP/GPG Key ID: D53FDCB1