[Pkg-ayatana-devel] Bug#763211: libappindicator: FTBFS: src/app-indicator.c:480: Error: AppIndicator: multiple "@arg1" parameters for identifier "AppIndicator::new-label":

[Balint Reczey]

Hi David,


On Sun, 28 Sep 2014 18:47:01 +0200 David =?iso-8859-1?Q?Su=E1rez?=
<david.sephirot at gmail.com> wrote:
...
> 
> Hi,
> 
> During a rebuild of all packages in sid, your package failed to build on
> amd64.
> 
> Relevant part (hopefully):
> > /bin/bash ../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../../src -I..   -D_FORTIFY_SOURCE=2 -pthread -I/usr/include/libdbusmenu-gtk3-0.4 -I/usr/include/libdbusmenu-glib-0.4 -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng12 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/libindicator3-0.4  -Wall -Werror -DG_LOG_DOMAIN=\"libappindicator\" -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o libappindicator3_la-app-indicator.lo `test -f 'app-indicator.c' || echo '../../src/'`app-indicator.c
> > libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../src -I.. -D_FORTIFY_SOURCE=2 -pthread -I/usr/include/libdbusmenu-gtk3-0.4 -I/usr/include/libdbusmenu-glib-0.4 -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng12 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/libindicator3-0.4 -Wall -Werror -DG_LOG_DOMAIN=\"libappindicator\" -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wall -c ../../src/app-indicator.c  -fPIC -DPIC -o .libs/libappindicator3_la-app-indicator.o
> > ../../src/app-indicator.c: In function 'app_indicator_set_property':
> > ../../src/app-indicator.c:902:6: error: 'gtk_status_icon_set_title' is deprecated (declared at /usr/include/gtk-3.0/gtk/deprecated/gtkstatusicon.h:143) [-Werror=deprecated-declarations]
> >       gtk_status_icon_set_title(priv->status_icon, priv->title ? priv->title : "");
...
I have uploaded a fixed version to DELAYED/5.
Please see the debdiff attached.

Cheers,
Balint
-------------- next part --------------
diff -u libappindicator-0.4.92/debian/changelog libappindicator-0.4.92/debian/changelog
--- libappindicator-0.4.92/debian/changelog
+++ libappindicator-0.4.92/debian/changelog
@@ -1,3 +1,11 @@
+libappindicator (0.4.92-3.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Don't treat deprecated API usage as error during the build to fix FTBFS
+    (Closes: #763211)
+
+ -- Balint Reczey <balint at balintreczey.hu>  Fri, 31 Oct 2014 21:38:56 +0100
+
 libappindicator (0.4.92-3) unstable; urgency=medium
 
   * Team upload.
diff -u libappindicator-0.4.92/debian/rules libappindicator-0.4.92/debian/rules
--- libappindicator-0.4.92/debian/rules
+++ libappindicator-0.4.92/debian/rules
@@ -8,6 +8,9 @@
 export MONO_SHARED_DIR=$(CURDIR)
 export CSC=/usr/bin/mono-csc
 
+
+CFLAGS = $(shell dpkg-buildflags --get CFLAGS) -Wno-error=deprecated-declarations
+
 include /usr/share/cdbs/1/rules/patchsys-quilt.mk
 include /usr/share/cdbs/1/rules/autoreconf.mk
 include /usr/share/cdbs/1/rules/debhelper.mk
@@ -64,12 +67,13 @@
 binary-install/libappindicator1:: install-stamp install-stamp-gtk3
 	dh_makeshlibs -plibappindicator1
 
+
 configure-stamp-gtk3:
 	: # configure for GTK+ 3.0
 	rm -rf build-gtk3; \
 	mkdir build-gtk3; \
 	cd build-gtk3; \
-	$(DEB_CONFIGURE_SCRIPT_ENV) ../configure --with-gtk=3 \
+	$(DEB_BUILD_MAINT_OPTIONS) CFLAGS="$(CFLAGS)" ../configure --with-gtk=3 \
 		$(filter-out --enable-gtk-doc, $(filter-out --srcdir=%, $(DEB_CONFIGURE_NORMAL_ARGS) $(DEB_CONFIGURE_EXTRA_FLAGS))) \
 		--enable-gtk-doc=no; \
 	cd ..;