[Pkg-ayatana-devel] Bug#741804: indicator-applet: FTBFS: panel-applet.h:169:13: error: unknown type name 'GtkActionGroup'

[peter green]

Tags 741804 -patch
Thanks

This was blocking a transition in raspbian stretch and I decided to take 
a look to see if I could fix it before resorting to removal (since 
raspbian doesn't have an unstable I don't like to remove stuff from 
raspbian testing that is still in Debian unstable).

I applied Domenico Iezzi's patch to remove -DGTK_DISABLE_DEPRECATED and 
tried to build the package. Unfortunately it was no longer sufficient to 
make the package build and my attempts at fixing the build also failed.

The first problem I ran into was a build dependency problem. It seems 
libpanel-applet-4-dev has been replaced by libpanel-applet-dev so I 
changed that build dependency.

I then discovered that the .pc file for libpanel-applet had also changed 
name and updated configure.ac to match.

While looking into the configure problem I ran into incomplete cleanup 
by the clean target (config.log was left behind) causing unrepresentable 
changes to source errors.

Unfortunately after doing all of that the actual build failed with.

applet-main.c:878:3: warning: ‘gtk_action_group_new’ is deprecated 
(declared at /usr/include/gtk-3.0/gtk/deprecated/gtkactiongroup.h:175) 
[-Wdeprecated-declarations]
action_group = gtk_action_group_new ("Indicator Applet Actions");
^
applet-main.c:879:3: warning: ‘gtk_action_group_set_translation_domain’ 
is deprecated (declared at 
/usr/include/gtk-3.0/gtk/deprecated/gtkactiongroup.h:252) 
[-Wdeprecated-declarations]
gtk_action_group_set_translation_domain (action_group, GETTEXT_PACKAGE);
^
applet-main.c:880:3: warning: ‘gtk_action_group_add_actions’ is 
deprecated (declared at 
/usr/include/gtk-3.0/gtk/deprecated/gtkactiongroup.h:210) 
[-Wdeprecated-declarations]
gtk_action_group_add_actions (action_group, menu_actions,
^
applet-main.c:883:45: warning: passing argument 3 of 
‘panel_applet_setup_menu’ from incompatible pointer type
panel_applet_setup_menu(applet, menu_xml, action_group);
^
In file included from applet-main.c:27:0:
/usr/include/gnome-panel/libpanel-applet/panel-applet.h:154:20: note: 
expected ‘struct GSimpleActionGroup *’ but argument is of type ‘struct 
GtkActionGroup *’
void panel_applet_setup_menu (PanelApplet *applet,
^
applet-main.c:883:3: error: too few arguments to function 
‘panel_applet_setup_menu’
panel_applet_setup_menu(applet, menu_xml, action_group);
^
In file included from applet-main.c:27:0:
/usr/include/gnome-panel/libpanel-applet/panel-applet.h:154:20: note: 
declared here
void panel_applet_setup_menu (PanelApplet *applet,
^
Makefile:597: recipe for target 'indicator_applet-applet-main.o' failed
make[3]: *** [indicator_applet-applet-main.o] Error 1
make[3]: Leaving directory '/indicator-applet-0.5.0/src'
Makefile:438: recipe for target 'all-recursive' failed
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory '/indicator-applet-0.5.0'
Makefile:369: recipe for target 'all' failed
make[1]: *** [all] Error 2
make[1]: Leaving directory '/indicator-applet-0.5.0'
/usr/share/cdbs/1/class/makefile.mk:47: recipe for target 
'debian/stamp-makefile-build' failed
make: *** [debian/stamp-makefile-build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2
root at odroidu2:/indicator-applet-0.5.0#

It seems that panel_applet_setup_menu has added an extra parameter and 
changed the type of an existing one. The only documentation I could find 
with a quick google was clear as mud and does not give me confidence to 
attempt a fix. This really needs to be looked at by someone more 
familiar with said library.

A debdiff of what I have done so far is attatched.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: indicator-applet.debdiff
URL: <http://lists.alioth.debian.org/pipermail/pkg-ayatana-devel/attachments/20150704/d353ba43/attachment.ksh>