[Pkg-ayatana-devel] Bug#883339: properties-cpp: please make the build reproducible

[Chris Lamb]

Source: properties-cpp
Version: 0.0.1~bzr17+repack1-1
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that properties-cpp could not be built reproducibly.

This is due to absolute build paths appearing in the documentation.

Patch attached that stops absolute filenames in the Doxygen docs,
as well as excluding the (slightly pointless) TCL configuration 
file from the docs (which embeds the absolute build path).


 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/patches/1002_reproducible-builds.patch	1970-01-01 01:00:00.000000000 +0100
--- b/debian/patches/1002_reproducible-builds.patch	2017-12-02 15:44:55.127286414 +0000
@@ -0,0 +1,24 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby at debian.org>
+Last-Update: 2017-12-02
+
+--- properties-cpp-0.0.1~bzr17+repack1.orig/doc/Doxyfile.in
++++ properties-cpp-0.0.1~bzr17+repack1/doc/Doxyfile.in
+@@ -119,7 +119,7 @@ INLINE_INHERITED_MEMB  = NO
+ # path before files name in the file list and in the header files. If set
+ # to NO the shortest path that makes the file name unique will be used.
+ 
+-FULL_PATH_NAMES        = YES
++FULL_PATH_NAMES        = NO
+ 
+ # If the FULL_PATH_NAMES tag is set to YES then the STRIP_FROM_PATH tag
+ # can be used to strip a user-defined part of the path. Stripping is
+@@ -714,7 +714,7 @@ EXCLUDE_SYMLINKS       = NO
+ # against the file with absolute path, so to exclude all test directories
+ # for example use the pattern */test/*
+ 
+-EXCLUDE_PATTERNS       =
++EXCLUDE_PATTERNS       = */DartConfiguration.tcl
+ 
+ # The EXCLUDE_SYMBOLS tag can be used to specify one or more symbol names
+ # (namespaces, classes, functions, etc.) that should be excluded from the
--- a/debian/patches/1002_reproducible-builds.patch~	1970-01-01 01:00:00.000000000 +0100
--- b/debian/patches/1002_reproducible-builds.patch~	2017-12-02 15:34:53.503788413 +0000
@@ -0,0 +1,15 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby at debian.org>
+Last-Update: 2017-12-02
+
+--- properties-cpp-0.0.1~bzr17+repack1.orig/doc/Doxyfile.in
++++ properties-cpp-0.0.1~bzr17+repack1/doc/Doxyfile.in
+@@ -119,7 +119,7 @@ INLINE_INHERITED_MEMB  = NO
+ # path before files name in the file list and in the header files. If set
+ # to NO the shortest path that makes the file name unique will be used.
+ 
+-FULL_PATH_NAMES        = YES
++FULL_PATH_NAMES        = NO
+ 
+ # If the FULL_PATH_NAMES tag is set to YES then the STRIP_FROM_PATH tag
+ # can be used to strip a user-defined part of the path. Stripping is
--- a/debian/patches/series	2017-12-02 15:24:19.170287841 +0000
--- b/debian/patches/series	2017-12-02 15:34:52.091776364 +0000
@@ -1 +1,2 @@
 1001_fix-FTBFS-in-gtest.patch
+1002_reproducible-builds.patch
--- a/debian/rules	2017-12-02 15:24:19.170287841 +0000
--- b/debian/rules	2017-12-02 15:39:28.161721140 +0000
@@ -31,6 +31,7 @@
 	cd debian/tmp/usr/share/doc/libproperties-cpp-doc/html/ && symlinks -c .
 	rmdir debian/tmp/usr/share/doc/properties-cpp/html/
 	rm debian/tmp/usr/share/doc/libproperties-cpp-doc/html/*.md5
+	rm debian/tmp/usr/share/doc/libproperties-cpp-doc/html/results.txt
 	dh_install
 
 ## http://wiki.debian.org/onlyjob/get-orig-source