[Pkg-ayatana-devel] Bug#876613: Bug#876613: libdbusmenu FTBFS with gtk-doc-tools 1.26: gtkdoc-check: error: unrecognized arguments: --quiet --keep-going -m=quick --GTestLogFD=4

[Mike Gabriel]

Hi Adrian,

IMHO this bug needs to be fixed in glib's gtester.c. See analysis below.

On Sun, Sep 24, 2017 at 02:40:23AM +0300, Adrian Bunk wrote:
> Source: libdbusmenu
> Version: 16.04.1+17.04.20170109.1-4
> Severity: serious
> 
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/libdbusmenu.html
> 
> ...
> FAIL: test_libdbusmenu_glib_gtkdoc
> ==================================
> 
> TEST: /usr/bin/gtkdoc-check... (pid=22696)
> usage: gtkdoc-check [-h] [--version]
> gtkdoc-check: error: unrecognized arguments: --quiet --keep-going -m=quick --GTestLogFD=4
> FAIL: /usr/bin/gtkdoc-check
> FAIL test_libdbusmenu_glib_gtkdoc (exit status: 1)
> 
> FAIL: test_libdbusmenu_gtk_gtkdoc
> =================================
> 
> TEST: /usr/bin/gtkdoc-check... (pid=22617)
> usage: gtkdoc-check [-h] [--version]
> gtkdoc-check: error: unrecognized arguments: --quiet --keep-going -m=quick --GTestLogFD=4
> FAIL: /usr/bin/gtkdoc-check
> FAIL test_libdbusmenu_gtk_gtkdoc (exit status: 1)
> 
> ============================================================================
> Testsuite summary for libdbusmenu 16.04.0
> ============================================================================
> # TOTAL: 16
> # PASS:  14
> # SKIP:  0
> # XFAIL: 0
> # FAIL:  2
> # XPASS: 0
> # ERROR: 0
> ============================================================================
> See tests/test-suite.log
> Please report to ted at canonical.com
> ============================================================================
> Makefile:1946: recipe for target 'test-suite.log' failed
> make[5]: *** [test-suite.log] Error 1


13:06 * sunweaver is currently looking at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=876613
13:06 -zwiebelbot:#debian-gnome- Debian#876613: libdbusmenu FTBFS with gtk-doc-tools 1.26: gtkdoc-check: error: unrecognized arguments: --quiet --keep-going 
          -m=quick --GTestLogFD=4 - https://bugs.debian.org/876613
13:07 < sunweaver> the cause is this:
13:07 < sunweaver> gtkdoc-check was ported from Perl to Python recently.
13:07 < sunweaver> in Perl, the arguments were parsed using Getopt::Long without a ".. or die ("invalid cmdline options");
13:08 < sunweaver> so virtually, gtkdoc-check tolerated any set of cmdline parameters.
13:08 < sunweaver> now it has been ported to Python using the argparser.
13:08 < sunweaver> and this is very strict about unknown options.
13:09 < sunweaver> secondly, the gtester binary from glib-2.0 does something really weird.
13:09 < sunweaver> It forwards its own cmdline options to the test application.
13:10 < sunweaver> so a "gtester --verbose -k /usr/bin/gtkdoc-check"
13:10 < sunweaver> ends up with the gtester default cmdline options being handed over to gtkdoc-check:
13:11 < sunweaver> which results in "gtkdoc-check --quiet --keep-going -m=quick --GTestLogFD=4"
13:11 < sunweaver> however, this fails due to the recent portage of gtkdoc-check from Perl to Python.
13:12 < sunweaver> IMHO, the issue is in gtester.c, which calls the test application with gtester's own cmdline options.

Mike

-- 

mike gabriel aka sunweaver (Debian Developer)
fon: +49 (1520) 1976 148

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: sunweaver at debian.org, http://sunweavers.net

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-ayatana-devel/attachments/20171005/66551e5c/attachment.sig>