[Pkg-ayatana-devel] Bug#1086191: libayatana-appindicator: FTBFS on riscv64 due to testsuite failure

[Aurelien Jarno]

Source: libayatana-appindicator
Version: 0.5.93+really-1
Severity: serious
Tags: ftbfs patch
Justification: fails to build from source (but built successfully in the past)
X-Debbugs-Cc: debian-riscv at lists.debian.org
User: debian-riscv at lists.debian.org
Usertags: riscv64

Dear maintainer,

libayatana-appindicator fails to build from source on riscv64:

| test 1
|     Start 1: test-libappindicator-fallback
| 
| 1: Test command: /<<PKGBUILDDIR>>/build/gtk3/tests/test-libappindicator-fallback
| 1: Working Directory: /<<PKGBUILDDIR>>/build/gtk3/tests
| 1: Test timeout computed to be: 1500
| 1: DBus daemon: unix:path=/tmp/dbus-JKXCPlWVTi,guid=fb07080c502a2dbe740f8f4366fbb76d
| 1: Watcher: Started with PID: 2042977
| 1: Item   : Started with PID: 2042978
| 1: 
| 1: ** (process:2042977): ERROR **: 08:48:45.611: Unable to get name owner
| 1: Watcher: Exited with status 5
| 1: dbus-daemon[2042973]: [session uid=2952 pid=2042973] Activating service name='org.a11y.Bus' requested by ':1.1' (uid=2952 pid=2042978 comm="/<<BUILDDIR>>/libayatana-appindicator-0")
| 1: dbus-daemon[2042973]: [session uid=2952 pid=2042973] Successfully activated service 'org.a11y.Bus'
| 1: dbus-daemon[2042989]: Activating service name='org.a11y.atspi.Registry' requested by ':1.0' (uid=2952 pid=2042978 comm="/<<BUILDDIR>>/libayatana-appindicator-0")
| 1: dbus-daemon[2042989]: Successfully activated service 'org.a11y.atspi.Registry'
| 1: DBus daemon: SpiRegistry daemon is running with well-known name - org.a11y.atspi.Registry
| 1: Item   : Exited with status 256
| 1: Watcher: Shutting down
| 1: Item: Shutting down
| 1: DBus daemon: Shutdown
| 1/4 Test #1: test-libappindicator-fallback ....***Failed   31.33 sec
| DBus daemon: unix:path=/tmp/dbus-JKXCPlWVTi,guid=fb07080c502a2dbe740f8f4366fbb76d
| Watcher: Started with PID: 2042977
| Item   : Started with PID: 2042978
| 
| ** (process:2042977): ERROR **: 08:48:45.611: Unable to get name owner
| Watcher: Exited with status 5
| dbus-daemon[2042973]: [session uid=2952 pid=2042973] Activating service name='org.a11y.Bus' requested by ':1.1' (uid=2952 pid=2042978 comm="/<<BUILDDIR>>/libayatana-appindicator-0")
| dbus-daemon[2042973]: [session uid=2952 pid=2042973] Successfully activated service 'org.a11y.Bus'
| dbus-daemon[2042989]: Activating service name='org.a11y.atspi.Registry' requested by ':1.0' (uid=2952 pid=2042978 comm="/<<BUILDDIR>>/libayatana-appindicator-0")
| dbus-daemon[2042989]: Successfully activated service 'org.a11y.atspi.Registry'
| DBus daemon: SpiRegistry daemon is running with well-known name - org.a11y.atspi.Registry
| Item   : Exited with status 256
| Watcher: Shutting down
| Item: Shutting down
| DBus daemon: Shutdown
 
...
 
| 75% tests passed, 1 tests failed out of 4
| 
| Total Test time (real) =  71.74 sec
| 
| The following tests FAILED:
| 	  1 - test-libappindicator-fallback (Failed)
| Errors while running CTest

The full build log is available there:
https://buildd.debian.org/status/fetch.php?pkg=libayatana-appindicator&arch=riscv64&ver=0.5.93%2Breally-1&stamp=1727772595&raw=0

After investigation, it appears that the issue is due to a hardcoded
delay in the test that this too low for the hardware used by the riscv64
build daemons. The following patch fixes the issue:

--- libayatana-appindicator-0.5.93+really.orig/tests/test-libappindicator-fallback-watcher.c
+++ libayatana-appindicator-0.5.93+really/tests/test-libappindicator-fallback-watcher.c
@@ -72,7 +72,7 @@ main (int argv, char ** argc)
         return 1;
     }
 
-    g_usleep (500000);
+    g_usleep (750000);
     gboolean bOwner = FALSE;
     GVariant *pResult = g_dbus_proxy_call_sync (pProxy, "NameHasOwner", g_variant_new ("(s)", "org.test"), G_DBUS_CALL_FLAGS_NONE, -1, NULL, &pError);

Regards
Aurelien