[pkg-bacula-devel] [pkg-bacula-commits] [SCM] Bacula, a network backup, recovery and verification program branch, master, updated. debian/5.2.6+dfsg-2-20-g82737eb

[Luca Capello]

Hi Bart!

On Mon, 30 Jul 2012 15:13:30 +0200, Bart Swedrowski wrote:
> The following commit has been merged in the master branch:
> commit 82737eb31724a617974ba6cd339f543db467fe8b
> Author: Bart Swedrowski <bart at timedout.org>
> Date:   Mon Jul 30 13:03:42 2012 +0100
>
>     Fix hostname substitution in debian/bacula-console.postinst
>
> diff --git a/debian/bacula-console.postinst b/debian/bacula-console.postinst
> index 319fe7b..c439d0a 100644
> --- a/debian/bacula-console.postinst
> +++ b/debian/bacula-console.postinst
> @@ -18,10 +18,11 @@ case "$1" in
>  		TARGET=$DSTDIR/$CONFIG.dist
>  	fi
>  
> -	sed -e "s~@debian_hostname@~localhost~" \
> +	sed -e s~@debian_hostname@~`hostname`~ \
>  	-e s~XXX_DIRPASSWORD_XXX~$DIRPASSWD~ \
>  		< $SRCDIR/$CONFIG > $TARGET

Two notes:

1) what is the reason to remove the double-quotes?  It is an unrelated
   change and it should be then committed separately.

2) the sed change should be fixed in bacula-console-qt.postinst and
   bacula-traymonitor.postinst as well, before any new upload.

> +        # Harden permissions, so that passwords can not be looked at
>  	chown root:bacula $TARGET
>  	chmod 640 $TARGET

Thank you for the comment, but again please do not record two different
unrelated things in the same commit.

Thx, bye,
Gismo / Luca
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-bacula-devel/attachments/20120803/1ec5e6bd/attachment.pgp>