[pkg-bacula-devel] [pkg-bacula-commits] [SCM] Bacula, a network backup, recovery and verification program branch, master, updated. debian/5.2.6+dfsg-2-25-g562d519

[Luca Capello]

Hi there!

On Mon, 06 Aug 2012 10:25:34 +0200, Alexander Golovko wrote:
> The following commit has been merged in the master branch:
> commit 562d51910458b777d5e0a5966ac1358c9f498997
> Author: Alexander Golovko <alexandro at ankalagon.ru>
> Date:   Mon Aug 6 12:24:54 2012 +0400
>
>     make adduser calls more clean
[...]
> 		if ! getent passwd bacula >/dev/null; then
>  			echo -n "Adding user 'bacula'... "
[...]
> +			adduser --quiet --system --home /var/lib/bacula --gecos Bacula --no-create-home --group bacula
> +			adduser --quiet bacula tape
> +			adduser --quiet bacula cdrom

What other adduser-caller scripts do?  On my sid 9 of them use --quiet
and 22 does not.

The adduser_3.113+nmu3 manpage is not completely clear:

--8<---------------cut here---------------start------------->8---
   Add a system user
       If called with one non-option argument and the --system option,
       adduser will add a system user. If a user with the same name
       already exists in the system uid range (or, if the uid is
       specified, if a user with that uid already exists), adduser will
       exit with a warning.  This warning can be suppressed by adding
       "--quiet".

   [...]

       --quiet
              Suppress informational messages, only show warnings and
              errors.
--8<---------------cut here---------------end--------------->8---

IMHO a proper solution would be to let adduser do its work without any
if/echo line, i.e. always creating the user.  But IIRC this has been
discussed at length in the past and there was no consensus.

Thx, bye,
Gismo / Luca
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-bacula-devel/attachments/20120810/241fc2ab/attachment.pgp>