[pkg-bacula-devel] [pkg-bacula-commits] [SCM] Bacula, a network backup, recovery and verification program branch, master, updated. debian/5.0.3-1-188-g83e100b

[Luca Capello]

Hi there!

On Wed, 13 Jun 2012 12:08:10 +0200, Luca Capello wrote:
> The following commit has been merged in the master branch:
> commit 40bc02d874192855b980180a15d7732c2fa133a1
> Author: Luca Capello <luca at pca.it>
> Date:   Wed Jun 13 10:43:34 2012 +0200
>
>     debian/bacula-director-common.bacula-director.init: restore
>     
>     When moving /etc/init.d/bacula-director to bacula-director-<dbtype>,
>     any local changes should be preserved.  It is impossible to do that
>     with dpkg-maintscript-helper, given that the new conffile is now
>     shipped by three different packages.  Thus, instead of error-prone
>     solutions and given that starting from upstream 5.2.7 there will be no
>     more for bacula-director-<dbtype> packages, it is useless to do this
          ^
Missing "need", sorry.

>     transition right now.  Thanks to piuparts.
>     
>     This reverts part of 1b033cf and c370db1.

Just to be clear, given that I was a bit sad to revert Hauke and
Alexander's work.

At first, I decided to fix the transition, which at least meant a notice
in debian/NEWS and:

--8<--bacula-director-common.postinst----start------------->8---
#!/bin/sh

set -e

# the init.d has been moved to bacula-director-<dbtype> packages:
# - mv_conffile can not be used since multiple packages now ship it
# - rm_conffile here and check in bacula-director-<dbtype> packages
dpkg-maintscript-helper rm_conffile \
  /etc/init.d/bacula-director -- "$@"
# - remove the symlinks, thanks to piuparts
if test "$1" = "configure" && dpkg --compare-versions "$2" lt "5.2.6+dfsg-1"; then
  update-rc.d bacula-director remove >/dev/null
fi

#DEBHELPER#

exit 0
--8<--bacula-director-common.postinst-----end--------------->8---

--8<--bacula-director-common.postrm-------start------------->8---
#!/bin/sh

set -e

# the init.d has been moved to bacula-director-<dbtype> packages:
# - mv_conffile can not be used since multiple packages now ship it
# - rm_conffile here and check in bacula-director-<dbtype> packages
dpkg-maintscript-helper rm_conffile \
  /etc/init.d/bacula-director -- "$@"

#DEBHELPER#

exit 0
--8<--bacula-director-common.postrm-------end--------------->8---

--8<--bacula-director-common.preinst------start------------->8---
#!/bin/sh

set -e

# the init.d has been moved to bacula-director-<dbtype> packages:
# - mv_conffile can not be used since multiple packages now ship it
# - rm_conffile here and check in bacula-director-<dbtype> packages
dpkg-maintscript-helper rm_conffile \
  /etc/init.d/bacula-director -- "$@"

#DEBHELPER#

exit 0
--8<--bacula-director-common.preinst------end--------------->8---

While considering how to do the check in the bacula-director-<dbtype>, I
thought about using the MD5 checksum for the bacula-director.init script
in bacula-director-common_5.0.3+dfsg-0.1.  I then remembered that
apache2.2-common is in a similar situation: it ships the init script,
while the real daemon is in one of the apache2-mpm-<model> packages.
Its init script checks if the daemon is present [1], so also given the
5.2.1 changed how the SQL backends are built [2][3], I decided to take
the easier path above.

[1] actually, it checks if the daemon is present and executable (even
    more correct), I forgot it, so fixed now:
      <http://anonscm.debian.org/gitweb/?p=pkg-bacula/bacula.git;a=commitdiff;h=8df560896499e8d8714708bce558c0e92a1a926c>
[2] <http://www.bacula.org/git/cgit.cgi/bacula/tree/bacula/ReleaseNotes?id=Release-5.2.1>
[3] sorry, I do not know why I thought it was 5.2.7, it was anyway too
    late to move the Debian package to that (wheezy should be freezing)

Thx, bye,
Gismo / Luca
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-bacula-devel/attachments/20120614/f5022c7c/attachment.pgp>