[pkg-bacula-devel] Bug#707803: bacula: copyright file missing after upgrade (policy 12.5)

[Andreas Beckmann]

Package: bacula
Version: 5.2.6+dfsg-9
Severity: serious
User: debian-qa at lists.debian.org
Usertags: piuparts

Hi,

a test with piuparts revealed that your package misses the copyright
file after an upgrade, which is a violation of Policy 12.5:
http://www.debian.org/doc/debian-policy/ch-docs.html#s-copyrightfile

After the upgrade /usr/share/doc/$PACKAGE/ is just an empty directory.

This was observed on the following upgrade paths:

  lenny -> squeeze -> wheezy -> jessie

>From the attached log (scroll to the bottom...):

  MISSING COPYRIGHT FILE: /usr/share/doc/bacula/copyright
  # ls -lad /usr/share/doc/bacula
  drwxr-xr-x 2 root root 40 May  8 15:22 /usr/share/doc/bacula
  # ls -la /usr/share/doc/bacula/
  total 0
  drwxr-xr-x   2 root root   40 May  8 15:22 .
  drwxr-xr-x 143 root root 3040 May  8 15:23 ..


Additional info may be available here:
http://wiki.debian.org/MissingCopyrightFile

Note that dpkg intentionally does not replace directories with symlinks
and vice versa, you need the maintainer scripts to do this.
See in particular the end of point 4 in
http://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-unpackphase

For switching from a directory to a symlink the *postinst* script
should do something like this:

        DOCDIR=/usr/share/doc/@@PACKAGE@@
        DOCLINK=@@OTHERPACKAGE@@

        if [ -d $DOCDIR ] && [ ! -L $DOCDIR ]; then
                rmdir $DOCDIR
                ln -s $DOCLINK $DOCDIR
        fi

For switching from a symlink to a directory, the *preinst* script
should do something like this:

        DOCDIR=/usr/share/doc/@@PACKAGE@@

        if [ -L $DOCDIR ]; then
                rm $DOCDIR
        fi


cheers,

Andreas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bacula_5.2.6+dfsg-9.log.gz
Type: application/x-gzip
Size: 47884 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-bacula-devel/attachments/20130511/d31fddbe/attachment-0001.bin>