[pkg-bacula-devel] git push for 9.0.5 ready

[Sven Hartge]

On 05.11.2017 21:50, Carsten Leonhardt wrote:

>>> I'll probably upload the current state later, testing migration is
>>> blocked by mariadb anyway...
>>
>> We should fix the "CacheRetention BIGINT UNSIGNED DEFAULT" confusion for
>> mysql before that. I did the same for the sqlite3 case during merging,
>> as you noticed and from looking at the code, I think "UNSIGNED" is the
>> correct value here. So fixing update_mysql_tables.in to also use
>> UNSIGNED would be correct, AFAICS.
> 
> My intuition says that the retention period will probably never be so
> high that the highest bit will be needed.

SIGNED BIGINT is only 292.271.023.045 years if you store seconds in it,
it could be a bit short if you use granite tablets to engrave your backups.

Joking aside: The data type has to be uniform and from looking at the
code and the other data types I think the intention was having it
UNSIGNED, to prevent it from being negative.

Grüße,
Sven.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-bacula-devel/attachments/20171105/6efd5ace/attachment.sig>