[Pkg-bareos-devel] Comments regarding bareos_14.2.1+20140930git1339225-1_amd64.changes

[Evgeni Golov]

Hi Joerg,

thanks for the review. I'll try to answer your questions below.
CCing upstream, who mostly worked on the packages.

On 10/25/2014 02:18 PM, Joerg Jaspert wrote:

> W: bareos source: debian-control-file-is-a-symlink
see below

> W: bareos source: diff-contains-substvars debian/univention-bareos.substvars
not used on Debian (only on Univention)

> W: bareos source: package-file-is-executable debian/copyright
Ups.

> W: bareos source: space-in-std-shortname-in-dep5-copyright other exceptions (paragraph at line 15)
> W: bareos source: bad-exception-format-in-dep5-copyright agpl-3.0 with bacula (paragraph at line 15)
Lintian is a bit hard here, we have AGPL3+ with a ton of exception, and
it somehow parses the line wrong. I did not dig into lintian code yet to
understand how to fix that.

> W: bareos source: out-of-date-standards-version 3.9.5 (current is 3.9.6)
:-)

> While the other W could be fixed too, the first one is a nice trigger
> to look deeper. And really, its a symlink, thats a first ever...
> 
> And then it goes to control.dummy (oh yuck) and that has a header that
> makes it a NO-GO for the archive.
> 
> In short, debian/control is NOT TO BE TOUCHED during build. Ever. At
> all.
> 
> So, this is either a plain reject, or you can show me that
> debian/control is NOT touched during builds. A quick look tends to get
> a reject. :/ (I would love if this ends in Debian and also Backports
> (to wheezy), but not this thing).

d/control *is* generated during build, but the result *should* be always
the same on Debian.

the generation logic takes the following facts:
1. version of QtGui is >= 4.6 (valid for squeeze, wheezy, jessie and sid)
2. lsb_release -i -s == Univention (never true on Debian)
3. configure option --with-python (always set in d/rules on Debian)

I would argue that the generation will always produce the same d/control
on Debian and is thus harmless. Yet I can understand if you would like
to have no (automatic) generation at all.

If you want, I could reupload with a static version of d/control
instead, but this will make Joerg Steffens more headache, as the version
in Debian will need special care in compare to the Debian packages
provided on bareos.org. But if that is the only way to get Bareos into
the archive, I think it is worth it.

Greets
Evgeni