[Pkg-bazaar-maint] Bug#688289: RFS: bzrtools/2.5+bzr786-3 [ITA] -- Bazaar VCS tools

[Andrew Starr-Bochicchio]

On Fri, Sep 21, 2012 at 2:16 AM, Eric <eric at azrockets.org> wrote:
> I am looking for a sponsor for the package "bzrtools", which I have recently
> adopted.

Hi Eric,

Sorry for taking so long to get back to you about sponsoring this
package. I'm part of the Debian Bazaar maintenance team, [1] but have
just reacently been made a full Debian Developer. So, I can now
actually sponsor the upload myself.

I my previous message, I suggested maintaining bzrtools as part of the
team. To expand on that a bit; I mean to maintain it in the team bzr
repository that is listed in the Vcs-Bzr field in debian/control. [2]
For now, I would simply import the uploaded package into the
repository or merge a branch you host on Launchpad or some other
location. After a few uploads, I could officially add you to the team
so that you could commit directly to the packaging repository. If
you'd like to do this, leave "Debian Bazaar Maintainers
<pkg-bazaar-maint at lists.alioth.debian.org>" in the maintainer field
and move your name to the Uploaders field. You'll also want to
subscribe to the mailing list. [3] It's fairly low traffic.

Now, finally onto the reviewing the package itself. These are all very
small issues, but now would be a great time to clean up the package.

1)

> bzrtools (2.5+bzr786-4) unstable; urgency=low

You don't actually need to bump the version number for uploads to
mentors. The version only needs to change for uploads that actually
enter Debian. Just use the version 2.5+bzr786-3, and condense all the
changes into one entry.

2)

There's a lintain warning:

W: bzrtools source: syntax-error-in-dep5-copyright line 8: Duplicate
field copyright.

You don't need to duplicate the copyright text. You can just do:

Files: *
Copyright: 200? Foo Bar <foo at example.com>
License: GPL-2+

Files: debian/*
Copyright: 200? Package <foo at example.com>
License: GPL-2+

License: GPL-2+
  License text can go here.

3)

And another:

P: bzrtools binary: maintainer-script-without-set-e preinst

More info here:
http://lintian.debian.org/tags/maintainer-script-without-set-e.html

4)

The debian/watch file seems to be failing:

$ uscan --report --verbose
-- Scanning for watchfiles in .
-- Found watchfile in ./debian
-- In debian/watch, processing watchfile line:
   opts="uversionmangle=s/(b(eta)?[0-9]+)$/~\\1/"
https://launchpad.net/bzrtools/+download
http://launchpad.net/bzrtools/.*/bzrtools-(.*)\.tar\.gz
uscan warning: In debian/watch,
  no matching hrefs for watch line
  https://launchpad.net/bzrtools/+download
http://launchpad.net/bzrtools/.*/bzrtools-(.*)\.tar\.gz
-- Scan finished

I think the second url should also be https.

5)

Another little thing that would be nice to add to the package if we're
going to upload it anyway is a Vcs-Browser field in debian/control
pointing to where the bazaar repo can be viewed on line:
http://anonscm.debian.org/loggerhead/pkg-bazaar/bzrtools/unstable

Thanks!

-- Andrew Starr-Bochicchio

   Ubuntu Developer <https://launchpad.net/~andrewsomething>
   Debian Developer <http://qa.debian.org/developer.php?login=asb>
   PGP/GPG Key ID: D53FDCB1

[1] http://alioth.debian.org/projects/pkg-bazaar
[2] http://bzr.debian.org/pkg-bazaar/bzrtools/unstable
[3] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-bazaar-maint