[pkg-boinc-devel] Bug#358650: FTBFS with G++ 4.1: extra qualification

[Martin Michlmayr]

Package: boinc
Version: 5.2.15-2
Severity: important
Tags: patch

Your package fails to build with G++ 4.1.  I'm filing this bug as
important for now, but when 4.1 will be the default compiler in
unstable (probably in a few weeks) I'll upgrade this to serious.

A patch is attached.


> Automatic build of boinc_5.2.15-2 on bigsur by sbuild/mips 1.106
...
> if g++ -DHAVE_CONFIG_H -I. -I. -I..  -fPIC -DPIC -I../lib -I../api -I../db -I../client -I../tools -I../sched  -pthread -include ../config.h -I/usr/lib/wx/include/gtk2-unicode-release-2.6 -I/usr/include/wx-2.6 -DGTK_NO_CHECK_CASTS -D__WXGTK__ -D_FILE_OFFSET_BITS=64 -D_LARGE_FILES -D_LARGEFILE_SOURCE=1 -DNO_GCC_PRAGMA  -I../wizards  -fPIC -DPIC -I../lib -I../api -I../db -I../client -I../tools -I../sched  -pthread -include ../config.h -I/usr/lib/wx/include/gtk2-unicode-release-2.6 -I/usr/include/wx-2.6 -DGTK_NO_CHECK_CASTS -D__WXGTK__ -D_FILE_OFFSET_BITS=64 -D_LARGE_FILES -D_LARGEFILE_SOURCE=1 -DNO_GCC_PRAGMA    -I../wizards -g -Wall -O2 -I/usr/include -I/usr/include/openssl -pthread -MT boinc_gui-BOINCBaseView.o -MD -MP -MF ".deps/boinc_gui-BOINCBaseView.Tpo" -c -o boinc_gui-BOINCBaseView.o `test -f 'BOINCBaseView.cpp' || echo './'`BOINCBaseView.cpp; \
> 	then mv -f ".deps/boinc_gui-BOINCBaseView.Tpo" ".deps/boinc_gui-BOINCBaseView.Po"; else rm -f ".deps/boinc_gui-BOINCBaseView.Tpo"; exit 1; fi
> /usr/include/wx-2.6/wx/hashmap.h: In member function 'wxLongToLongHashMap_wxImplementation_HashTable::Node** wxLongToLongHashMap_wxImplementation_HashTable::GetNodePtr(const long int&) const':
> /usr/include/wx-2.6/wx/hashmap.h:684: warning: dereferencing type-punned pointer will break strict-aliasing rules
> /usr/include/wx-2.6/wx/gdicmn.h: In member function 'wxStringToColourHashMap_wxImplementation_HashTable::Node** wxStringToColourHashMap_wxImplementation_HashTable::GetNodePtr(const wxString&) const':
> /usr/include/wx-2.6/wx/gdicmn.h:476: warning: dereferencing type-punned pointer will break strict-aliasing rules
> /usr/include/wx-2.6/wx/image.h: In member function 'wxImageHistogramBase_wxImplementation_HashTable::Node** wxImageHistogramBase_wxImplementation_HashTable::GetNodePtr(const long unsigned int&) const':
> /usr/include/wx-2.6/wx/image.h:123: warning: dereferencing type-punned pointer will break strict-aliasing rules
> /usr/include/wx-2.6/wx/protocol/http.h: In member function 'wxStringToStringHashMap_wxImplementation_HashTable::Node** wxStringToStringHashMap_wxImplementation_HashTable::GetNodePtr(const wxString&) const':
> /usr/include/wx-2.6/wx/protocol/http.h:21: warning: dereferencing type-punned pointer will break strict-aliasing rules
> /usr/include/wx-2.6/wx/cshelp.h: In member function 'wxLongToStringHashMap_wxImplementation_HashTable::Node** wxLongToStringHashMap_wxImplementation_HashTable::GetNodePtr(const long int&) const':
> /usr/include/wx-2.6/wx/cshelp.h:144: warning: dereferencing type-punned pointer will break strict-aliasing rules
> BOINCTaskBar.h: At global scope:
> BOINCTaskBar.h:79: error: extra qualification 'CTaskBarIcon::' on member 'IsBalloonsSupported'
> BOINCBaseView.h: In constructor 'CTaskItem::CTaskItem(wxString, wxString, wxInt32)':
> BOINCBaseView.h:51: warning: 'CTaskItem::m_strWebSiteLink' will be initialized after
> BOINCBaseView.h:48: warning:   'wxInt32 CTaskItem::m_iEventID'
> BOINCBaseView.h:38: warning:   when initialized here
> BOINCBaseView.h: In constructor 'CTaskItem::CTaskItem(wxString, wxString, wxString, wxInt32)':
> BOINCBaseView.h:51: warning: 'CTaskItem::m_strWebSiteLink' will be initialized after
> BOINCBaseView.h:48: warning:   'wxInt32 CTaskItem::m_iEventID'
> BOINCBaseView.h:41: warning:   when initialized here
> make[3]: *** [boinc_gui-BOINCBaseView.o] Error 1
> make[3]: Leaving directory `/build/tbm/boinc-5.2.15/clientgui'
> make[2]: *** [all-recursive] Error 1
> make[2]: Leaving directory `/build/tbm/boinc-5.2.15'
> make[1]: *** [all] Error 2
> make[1]: Leaving directory `/build/tbm/boinc-5.2.15'
> make: *** [build-stamp] Error 2


--- ./clientgui/BOINCTaskBar.h~	2006-03-23 18:10:17.000000000 +0000
+++ ./clientgui/BOINCTaskBar.h	2006-03-23 18:10:24.000000000 +0000
@@ -76,7 +76,7 @@
 #endif
 
 #ifndef __WXMSW__
-    inline bool CTaskBarIcon::IsBalloonsSupported() {
+    inline bool IsBalloonsSupported() {
         return false;
     }
 #endif

-- 
Martin Michlmayr
http://www.cyrius.com/