Bug#447320: boinc-manager: Failed to create a new account with "missing or bad parameter: user_name" on certain condition.

[Frank S. Thomas]

Hi,

First of all I want to thank you for this straightforward and detailed bug 
report. You've done a great job at analysing this error!

On Saturday 20 October 2007, Morita Sho wrote:
> Since 5th field in /etc/passwd is optional, boinc-manager should not
> assumes it is non-empty. I have some idea to fix (or mitigate) this
> problem.
>  * Add inputbox for user_name to the "Attach to project" dialog and
>    use wxGetUserName() as its default value.
>  * Use other non-empty value if wxGetUserName() returns ""

Since one can change the user name later on the project's web site and it is 
not required for login (only email and password are) I'd vote for your second 
proposed fix. I propose to use the login name (first field in /etc/passwd) 
for user_name if wxGetUserName() returns an empty string. Here is the patch 
I'm going to forward to the BOINC developers:

                 ai->user_name = (const char*)::wxGetUserName().mb_str();
+                if (ai->user_name.empty()) {
+                    ai->user_name = (const char*)::wxGetUserId().mb_str();
+                }

Thanks and regards,
Frank
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 202_use_uid_if_username_is_empty.patch
Type: text/x-diff
Size: 815 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-boinc-devel/attachments/20071020/ffd0ddf0/attachment-0001.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://lists.alioth.debian.org/pipermail/pkg-boinc-devel/attachments/20071020/ffd0ddf0/attachment-0001.pgp