Bug#520091: boinc-client: Init script incorrectly detects "--daemon" option

[René Mayorga]

tags 520091 + patch

On Tue, Mar 17, 2009 at 10:21:31AM +0000, Paul Saunders wrote:

Hi Paul!,

> The init script for boinc-client finds the "--daemon" option in
> /etc/default/boinc-client, even when it is not there. This appears to be
> due, in part, to checking the uninitialise variable $FOO for this
> option. In addition, the test of the result from grep seems unreliable. 

err, thanks for spoting this, it was a silly, really sillly error that I
introduce, I was making my local tests using this variable and the issue
was sitting for a lot of days on experimental and later on unstable.


> --- boinc-client.dpkg-dist	2009-03-17 09:18:06.000000000 +0000
> +++ boinc-client	2009-03-17 10:07:53.000000000 +0000
> @@ -55,13 +55,12 @@
>  fi
>  
>  if [ ! -z "$BOINC_OPTS" ]; then
> -	if [ ! `echo $FOO | grep  -- '--daemon' 1>/dev/null` ]; then
> -		log_warning_msg "\`--deamon' option detected \
> +	(echo $BOINC_OPTS | grep -- '--daemon' 1>/dev/null) &&
> +		log_warning_msg "\`--daemon' option detected \
>  			on /etc/default/boinc-client, this \
>  			can cause problems on boinc. The option \
>  			will be suppressed"
> -			BOINC_OPTS=`echo "$BOINC_OPTS" | sed 's/--daemon//'`
> -	fi
> +	BOINC_OPTS=`echo "$BOINC_OPTS" | sed 's/--daemon//g'`
>  fi

Your patch is ok, I'll prepare a new version this weekend.

Thanks again for your bug report and your patch.

Cheers.
-- 
Rene Mauricio Mayorga   |  jabber: rmayorga at jabber.org
http://rmayorga.org     |  
--------------------------------------------------
08B6 58AB A691 DD56 C30B  8D37 8040 19FA A209 C305
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-boinc-devel/attachments/20090317/a68c9139/attachment.pgp