Bug#537695: Patch uses "sensible-browser"

[salonh at t2.technion.ac.il]

hi,

Quoting Sandro Tosi <morph at debian.org>:

> hello,
> 
> On Sun, Mar 28, 2010 at 11:00:24PM +0200, Daniel Hahler wrote:
> > Here's the contents of debian/patches/003_use_sensible-browser.patch -
> > it appears to be using sensible-browser.
> >
> >
> > Author: Frank S. Thomas <frank at thomas-alfeld.de>
> >
> > Description: use sensible-browser only, because upstream's attempt to
> > start a browser fails miserably.
> > Disclaimer: This patch is Debian-specific. Don't use it for non Debian
> > packages.
> > The program "sensible-browser" is part of the essential package
> debianutils.
> >
> > --- boinc.orig/clientgui/hyperlink.cpp
> > +++ boinc/clientgui/hyperlink.cpp
> > @@ -171,7 +171,8 @@
> >  }
> >
> >  void wxHyperLink::ExecuteLink (const wxString &strLink) {
> > -    if (!wxLaunchDefaultBrowser(strLink)) {
> > +    wxString cmd = wxT("sensible-browser ") + strLink;
> > +    if (!::wxExecute(cmd, wxEXEC_ASYNC)) {
> >          wxString strDialogTitle = wxEmptyString;
> >          wxString strDialogMessage = wxEmptyString;
> 
> Shouldn't this bug be closed then? boinc-manager is using the right
> way to spawn a browser, s-b. The only other thing the maint could do
> is to document it in README.Debian or so, but I consider this patch
> already working and perfectly fitting the debian env (I verified and
> it works just fine)
> 
> Regards,
> -- 
> Sandro Tosi (aka morph, morpheus, matrixhasu)
> My website: http://matrixhasu.altervista.org/
> Me at Debian: http://wiki.debian.org/SandroTosi
> 

me intent was exactly that - README.Debian already mentions this, it just points
to the (if you're using gnome) wrong alternative to set:

:~$ cat /usr/share/doc/boinc-manager/README.Debian 
BOINC Manager for Debian
========================

This README file discusses some topics that are specific to Debian's
version of the BOINC Manager. Additional information is available on
the Debian Wiki:

  http://wiki.debian.org/BOINC


Setting the default web browser
-------------------------------

Debian's BOINC Manager uses a more reliable way to determine the web
browser by using the sensible-browser program. To change the default
web browser, run as root:
  
  % update-alternatives --config x-www-browser
  
and select your favorite. If this does not work, set the alternative
manually (Firefox is used in this example):

  % update-alternatives --set x-www-browser /usr/bin/firefox

--------------- end of quote ------------


it should just mention that in gnome systems, the alternative you should change
(if you want) is gnome-www-browser.

perhaps I should have been more clear about this in the first place..

regards,
alon