[SCM] BOINC packaging branch, master, updated. debian/7.0.33+dfsg-1-47-g04d8f16

[Steffen Möller]

Hi Gianfranco,

while I just look at it

On 09/17/2012 01:21 PM, Gianfranco Costamagna wrote:
> diff --git a/debian/patches/opendir_error_messages.patch b/debian/patches/opendir_error_messages.patch
> index 916d354..11d385d 100644
> --- a/debian/patches/opendir_error_messages.patch
> +++ b/debian/patches/opendir_error_messages.patch
> @@ -89,3 +89,23 @@ Index: boinc/lib/filesys.cpp
....
> +@@ -579,8 +583,8 @@
> +     fclose(dst);
> +     // Copy file's ownership, permissions to the extent we are allowed
> +     lstat(orig, &sbuf);             // Get source file's info
if lstat fails, you can already return with ERR_FWRITE, I tend to think.
At least that return value should be set.

Cheers,

Steffen

> +-    chown(newf, sbuf.st_uid, sbuf.st_gid);
> +-    chmod(newf, sbuf.st_mode);
> ++    if (chown(newf, sbuf.st_uid, sbuf.st_gid)) retval=ERR_FWRITE;
> ++    if (chmod(newf, sbuf.st_mode)) retval=ERR_FWRITE;
> +     return retval;
> + #endif
> + }
>