Comments regarding boinc-app-seti_7.00~svn1883-2_amd64.changes

[Gianfranco Costamagna]

----- Messaggio originale -----

> Da: Paul Richards Tagliamonte <ftpmaster at ftp-master.debian.org>
> A: Debian BOINC Maintainers <pkg-boinc-devel at lists.alioth.debian.org>; Gianfranco Costamagna <costamagnagianfranco at yahoo.it>; moeller at debian.org
> Cc: Debian FTP Masters <ftpmaster at ftp-master.debian.org>
> Inviato: Domenica 14 Luglio 2013 20:07
> Oggetto: Comments regarding boinc-app-seti_7.00~svn1883-2_amd64.changes
> 
> Howdy,
> 
Hi Paul!

> During a routine NEW process I've found some things that would be nice to 
> get
> fixed in the next upload.
> 
> Your d/copyright is missing some Independent JPEG Group licensing info.
> 
mmm I see the 003_dont_use_own_jpeglib_and_glut.patch patch that disables building of jpeg files in configure.ac script...
Isn't better to just exclude that directory from the source tree in the next upload?
I honestly prefer to directly drop that kind of directories, instead of having them and don't use them.
(don't know if other developers have other points)

we need also to drop "glut" from copyright file, we don't include it anymore in the source tree.
and vector_lib/ too, don't know how long ago it was included...
> In addition I see some files copyright MIT that aren't noted in the 
> copyright.
> 
./install-sh:# Copyright 1991 by the Massachusetts Institute of Technology
./client/vector/hires_timer.h://       Copyright (c) 2003,2006 Massachusets Institute of Technology
./client/vector/analyzeFuncs_vector.cpp://       Copyright (c) 2003,2006 Massachusets Institute of Technology
./client/vector/sighandler.h://       Copyright (c) 2003,2006 Massachusets Institute of Technology
./client/vector/x86_ops.h://       Copyright (c) 2003,2006 Massachusets Institute of Technology
./client/vector/hires_timer.cpp://       Copyright (c) 2003,2006 Massachusets Institute of Technology
./client/win_build/fftw3.h: * Copyright (c) 2003, 2007-11 Massachusetts Institute of Technology
./db/sqlmysql.cpp://       Copyright (c) 2003,2006-2011 Massachusets Institute of Technology
./splitter_fft/fftw.h: * Copyright (c) 1997,1998 Massachusetts Institute of Technology
./COPYRIGHT://       Copyright (c) 2003,2006 Massachusets Institute of Technology
./splitter_pfb/fftw.h: * Copyright (c) 1997,1998 Massachusetts Institute of Technology

I honestly never tweaked the copyright file, could anybody please tell me how to add them? should I just add MIT or list the entire set of files?

> 
> Thanks!
>   Paul

Thanks to you for caring!

Gianfranco
>