boinc-app-seti doesn't build anymore on armhf

[Gianfranco Costamagna]

Hi boinc-app-seti developers (sorry, but I fail to find a place where to report seti issues, please forward where
appropriate)


I found a build failure on the latest svn3363 on armhf
the log is following
g++ -DHAVE_CONFIG_H -I. -I../../client -I..  -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -I/usr/include/boinc -I/usr/include/boinc/lib -I/usr/include/boinc/api -O3 -I/usr/include -I/usr/include/openssl  -fPIC -DPIC -DHAVE_CONFIG_H -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -I/usr/include/boinc -I/usr/include/boinc/lib -I/usr/include/boinc/api -O3 -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -I/usr/include/boinc -I/usr/include/boinc/lib -I/usr/include/boinc/api -O3 -I/usr/include -I/usr/include/openssl -DHAVE_CONFIG_H -DTEXT_UI -DNDEBUG -DCLIENT -I../../db -I../../client -I../../client/win_build -I/usr/include/boinc -I/usr/include/boinc/api -I/usr/include/boinc/lib -I/usr/include/boinc/sched -I/usr/include/boinc/db -I/usr/include/boinc -pthread   -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -I/usr/include/boinc -I/usr/include/boinc/lib -I/usr/include/boinc/api -O3 -I/usr/include -I/usr/include/openssl -MT seti_boinc-analyzeFuncs_vfp_aux.o -MD -MP -MF .deps/seti_boinc-analyzeFuncs_vfp_aux.Tpo -c -o seti_boinc-analyzeFuncs_vfp_aux.o `test -f 'vector/analyzeFuncs_vfp_aux.cpp' || echo '../../client/'`vector/analyzeFuncs_vfp_aux.cpp
../../client/main.cpp: In function 'int main(int, char**)':
../../client/main.cpp:204:8: warning: variable 'standalone' set but not used [-Wunused-but-set-variable]
bool standalone = false;
^
../../client/vector/analyzeFuncs_vfp_aux.cpp: In function 'void v_pfsubTranspose(float*, float*, int, int)':
../../client/vector/analyzeFuncs_vfp_aux.cpp:68:24: error: there are no arguments to 'pld' that depend on a template parameter, so a declaration of 'pld' must be available [-fpermissive]
pld(out+j*yline);
^
../../client/vector/analyzeFuncs_vfp_aux.cpp:68:24: note: (if you use '-fpermissive', G++ will accept your code, but allowing the use of an undeclared name is deprecated)
../../client/vector/analyzeFuncs_vfp_aux.cpp:78:25: error: there are no arguments to 'pld' that depend on a template parameter, so a declaration of 'pld' must be available [-fpermissive]
pld(in+j*xline+x);
^
../../client/vector/analyzeFuncs_vfp_aux.cpp: In instantiation of 'void v_pfsubTranspose(float*, float*, int, int) [with int x = 2]':
../../client/vector/analyzeFuncs_vfp_aux.cpp:93:55:   required from here
../../client/vector/analyzeFuncs_vfp_aux.cpp:68:12: error: 'pld' was not declared in this scope
pld(out+j*yline);
^
../../client/vector/analyzeFuncs_vfp_aux.cpp:78:12: error: 'pld' was not declared in this scope
pld(in+j*xline+x);
^
../../client/vector/analyzeFuncs_vfp_aux.cpp: In instantiation of 'void v_pfsubTranspose(float*, float*, int, int) [with int x = 4]':
../../client/vector/analyzeFuncs_vfp_aux.cpp:118:55:   required from here
../../client/vector/analyzeFuncs_vfp_aux.cpp:68:12: error: 'pld' was not declared in this scope
pld(out+j*yline);
^
../../client/vector/analyzeFuncs_vfp_aux.cpp:78:12: error: 'pld' was not declared in this scope
pld(in+j*xline+x);
^
../../client/vector/analyzeFuncs_vfp_aux.cpp: In instantiation of 'void v_pfsubTranspose(float*, float*, int, int) [with int x = 8]':
../../client/vector/analyzeFuncs_vfp_aux.cpp:154:55:   required from here
../../client/vector/analyzeFuncs_vfp_aux.cpp:68:12: error: 'pld' was not declared in this scope
pld(out+j*yline);
^
../../client/vector/analyzeFuncs_vfp_aux.cpp:78:12: error: 'pld' was not declared in this scope
pld(in+j*xline+x);
^

https://buildd.debian.org/status/fetch.php?pkg=boinc-app-seti&arch=armhf&ver=8.00~svn3363-1&stamp=1454342197

I patched it by reverting a pld function deletion:
--- boinc-app-seti-8.00~svn3363.orig/client/vector/analyzeFuncs_vfp_aux.cpp
+++ boinc-app-seti-8.00~svn3363/client/vector/analyzeFuncs_vfp_aux.cpp
@@ -48,6 +48,14 @@
#include "asmlib.h"
#include "pulsefind.h"

+inline void pld(void *arg1,const int arg2=0) {
+    __asm__ __volatile__ (
+      "pld [%0,%1]\n"
+      : 
+      : "r" (arg1), "Jr" (arg2)
+    );
+}
+

template <int x>
inline void v_pfsubTranspose(float *in, float *out, int xline, int yline) {


but I would like to have a feedback from you!

cheers,

Gianfranco