Bug#1034216: boinc-client: dh_installsystemd doesn't handle files in /usr/lib/systemd/system

[Cyril Brulebois]

Control: tag -1 patch pending

Hi,

bigon at debian.org <bigon at debian.org> (2023-04-11):
> This is not supported by the version of dh_installsystemd/debhelper currently
> in unstable and bookworm (See: #1031695). That means that currently your
> service might not be enabled at boot and/or started as expected.
> 
> With the freeze currently in effect, debhelper will not be fixed for bookworm.
> 
> As a result, could you please move these files to /lib/systemd/system instead
> so they are properly detected by debhelper?
> As soon as debhelper is supporting (not until bookworm+1 aka Trixie) you will
> be able to move them back to the newer location.

Minimal source debdiff attached.

The resulting binary debdiff is attached as well (limited to boinc-client).


Maintainer: I'm uploading to DELAYED/5, it can be either rescheduled to
DELAYED/0 if you're happy with the changes right now, or be superseded
by an upload of yours if that happens before the delay is over.


Cheers,
-- 
Cyril Brulebois (kibi at debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: boinc+systemd.diff
Type: text/x-diff
Size: 1109 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-boinc-devel/attachments/20230425/c0d9f082/attachment.diff>
-------------- next part --------------
[The following lists of changes regard files as different if they have
different names, permissions or owners.]

Files in second .deb but not in first
-------------------------------------
-rw-r--r--  root/root   /lib/systemd/system/boinc-client.service

Files in first .deb but not in second
-------------------------------------
-rw-r--r--  root/root   /usr/lib/systemd/system/boinc-client.service
-rw-r--r--  root/root   /usr/share/doc/boinc-client/changelog.Debian.amd64.gz

No differences were encountered between the conffiles files

Control files: lines which differ (wdiff format)
------------------------------------------------
Depends: debconf (>= 0.5) | debconf-2.0, python3:any, libboinc7 (= [-7.20.5+dfsg-1+b2),-] {+7.20.5+dfsg-1.1),+} libc6 (>= 2.34), libcurl4 (>= 7.16.2), libgcc-s1 (>= 3.3.1), libstdc++6 (>= 11), libx11-6, libxss1, zlib1g (>= 1:1.1.4), adduser, ca-certificates, lsb-base (>= 3.0-6)
Source: boinc [-(7.20.5+dfsg-1)-]
Version: [-7.20.5+dfsg-1+b2-] {+7.20.5+dfsg-1.1+}

Postinst files: lines which differ (wdiff format)
-------------------------------------------------
# Automatically added by [-dh_installinit/13.11.3-] {+dh_installinit/13.11.4+}
	{+fi+}
{+fi+}
{+# End automatically added section+}
{+# Automatically added by dh_installsystemd/13.11.4+}
{+if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then+}
{+	# The following line should be removed in trixie or trixie+1+}
{+	deb-systemd-helper unmask 'boinc-client.service' >/dev/null || true+}
{++}
{+	# was-enabled defaults to true, so new installations run enable.+}
{+	if deb-systemd-helper --quiet was-enabled 'boinc-client.service'; then+}
{+		# Enables the unit on first installation, creates new+}
{+		# symlinks on upgrades if the unit file has changed.+}
{+		deb-systemd-helper enable 'boinc-client.service' >/dev/null || true+}
{+	else+}
{+		# Update the statefile to add new symlinks (if any), which need to be+}
{+		# cleaned up on purge. Also remove old symlinks.+}
{+		deb-systemd-helper update-state 'boinc-client.service' >/dev/null || true+}
{+	fi+}
{+fi+}
{+# End automatically added section+}
{+# Automatically added by dh_installsystemd/13.11.4+}
{+if [ "$1" = "configure" ] || [ "$1" = "abort-upgrade" ] || [ "$1" = "abort-deconfigure" ] || [ "$1" = "abort-remove" ] ; then+}
{+	if [ -d /run/systemd/system ]; then+}
{+		systemctl --system daemon-reload >/dev/null || true+}
{+		if [ -n "$2" ]; then+}
{+			_dh_action=restart+}
{+		else+}
{+			_dh_action=start+}
{+		fi+}
{+		deb-systemd-invoke $_dh_action 'boinc-client.service' >/dev/null || true+}

Postrm files: lines which differ (wdiff format)
-----------------------------------------------
# Automatically added by [-dh_installinit/13.11.3-] {+dh_installinit/13.11.4+}
# Automatically added by [-dh_installdebconf/13.11.3-] {+dh_installsystemd/13.11.4+}
{+if [ "$1" = remove ] && [ -d /run/systemd/system ] ; then+}
{+	systemctl --system daemon-reload >/dev/null || true+}
{+fi+}
{+# End automatically added section+}
{+# Automatically added by dh_installsystemd/13.11.4+}
{+if [ "$1" = "purge" ]; then+}
{+	if [ -x "/usr/bin/deb-systemd-helper" ]; then+}
{+		deb-systemd-helper purge 'boinc-client.service' >/dev/null || true+}
{+	fi+}
{+fi+}
{+# End automatically added section+}
{+# Automatically added by dh_installdebconf/13.11.4+}

Preinst files: lines which differ (wdiff format)
------------------------------------------------
# Automatically added by [-dh_installinit/13.11.3-] {+dh_installinit/13.11.4+}

Prerm files: lines which differ (wdiff format)
----------------------------------------------
# Automatically added by [-dh_installinit/13.11.3-] {+dh_installsystemd/13.11.4+}
{+if [ -z "${DPKG_ROOT:-}" ] && [ "$1" = remove ] && [ -d /run/systemd/system ] ; then+}
{+	deb-systemd-invoke stop 'boinc-client.service' >/dev/null || true+}
{+fi+}
{+# End automatically added section+}
{+# Automatically added by dh_installinit/13.11.4+}

No differences were encountered between the templates files
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-boinc-devel/attachments/20230425/c0d9f082/attachment.sig>