[Pkg-cacti-maint] Bug#653897: [RFR] templates://cacti/{cacti.templates}

Thu Jan 5 17:43:53 UTC 2012

Please find, for review, the debconf templates and packages descriptions for the cacti source package.

This review will last from Thursday, January 05, 2012 to Sunday, January 15, 2012.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, a summary will be sent to the review bug report,
and a mail will be sent to this list with "[BTS]" as a subject tag.

Rationale:

--- cacti.old/debian/cacti.templates	2012-01-01 10:28:46.039467059 +0100
+++ cacti/debian/cacti.templates	2012-01-05 07:14:29.331696424 +0100
@@ -2,8 +2,8 @@
 Type: select
 __Choices: Apache2, None
 Default: Apache2
-_Description: Webserver type
- Please select the webserver type for which cacti should be automatically
+_Description: Web server:
+ Please select the web server for which Cacti should be automatically
  configured.

We always discouraged "contracted words" such as webserver, so
following our policy on this.

Adding colon at the end of the synopsis.

Capitalization of "Cacti".

  .
- Select "None" if you would like to configure your webserver by hand.
+ Select "None" if you would like to configure the web server manually.

"Manually" is more often used than "by hand". Could also be
"yourself".

Avoid "your web server". This might not be "mine"..:)


--- cacti.old/debian/control	2012-01-01 10:28:46.039467059 +0100
+++ cacti/debian/control	2012-01-05 07:17:35.884293523 +0100
@@ -13,15 +13,14 @@
 Depends: apache2 | apache | apache-ssl | apache-perl | httpd, libapache2-mod-php5 | php5, php5-mysql, php5-cli, php5-snmp, virtual-mysql-client, rrdtool, snmp, libphp-adodb (>= 4.50-1), ucf, dbconfig-common (>= 1.8.8), ${misc:Depends}
 Recommends: mysql-server, iputils-ping, logrotate
 Suggests: php5-ldap
-Description: Frontend to rrdtool for monitoring systems and services
- Cacti is a complete frontend to rrdtool, it stores all of the necessary
+Description: web frontend for graphing systems and services
monitoring data

Avoid capitalization of synopsis.

My proposal is not perfect. I wanted to say "for graphing the data
provided by systems and services monitoring", but had to short it
down.

I think Justin can boil comething better from this idea..:-)

+ Cacti is a complete frontend to rrdtool. It stores all of the necessary
  information to create graphs and populates them with data in a MySQL
- database.  The frontend is completely PHP driven.  Along with being able
+ database. It only uses PHP. Along with being able
  to maintain Graphs, Data Sources, and Round Robin Archives in a
- database, cacti handles the data gathering also.  There is also SNMP
+ database, Cacti also handles data gathering. It also includes SNMP
  support for those used to creating traffic graphs with MRTG.
  .
  This package requires a functional MySQL database server on either the
- installation host or remotely accessible system.  If you do not already
- have a database server available, you should also install mysql-server.
+ installation host or a remotely accessible system.

First  paragraph: make two sentences out of one. Avoid
"PHP-driven"...I kept the sentence but just mention this is "fully and
only PHP"

Reorder words in a sentence ("also") and properly capitalize Cacti

Drop last sentence that's proneto become obsolete in case MySQL
packages are renamed. Just say that it need an RDBMS....



-- 


-------------- next part --------------
Template: cacti/webserver
Type: select
__Choices: Apache2, None
Default: Apache2
_Description: Web server:
 Please select the web server for which Cacti should be automatically
 configured.
 .
 Select "None" if you would like to configure the web server manually.
-------------- next part --------------
--- cacti.old/debian/cacti.templates	2012-01-01 10:28:46.039467059 +0100
+++ cacti/debian/cacti.templates	2012-01-05 07:14:29.331696424 +0100
@@ -2,8 +2,8 @@
 Type: select
 __Choices: Apache2, None
 Default: Apache2
-_Description: Webserver type
- Please select the webserver type for which cacti should be automatically
+_Description: Web server:
+ Please select the web server for which Cacti should be automatically
  configured.
  .
- Select "None" if you would like to configure your webserver by hand.
+ Select "None" if you would like to configure the web server manually.
--- cacti.old/debian/control	2012-01-01 10:28:46.039467059 +0100
+++ cacti/debian/control	2012-01-05 18:39:20.460992639 +0100
@@ -13,15 +13,14 @@
 Depends: apache2 | apache | apache-ssl | apache-perl | httpd, libapache2-mod-php5 | php5, php5-mysql, php5-cli, php5-snmp, virtual-mysql-client, rrdtool, snmp, libphp-adodb (>= 4.50-1), ucf, dbconfig-common (>= 1.8.8), ${misc:Depends}
 Recommends: mysql-server, iputils-ping, logrotate
 Suggests: php5-ldap
-Description: Frontend to rrdtool for monitoring systems and services
- Cacti is a complete frontend to rrdtool, it stores all of the necessary
+Description: web frontend for graphing systems and services monitoring data
+ Cacti is a complete frontend to rrdtool. It stores all of the necessary
  information to create graphs and populates them with data in a MySQL
- database.  The frontend is completely PHP driven.  Along with being able
+ database. It only uses PHP. Along with being able
  to maintain Graphs, Data Sources, and Round Robin Archives in a
- database, cacti handles the data gathering also.  There is also SNMP
+ database, Cacti also handles data gathering. It also includes SNMP
  support for those used to creating traffic graphs with MRTG.
  .
  This package requires a functional MySQL database server on either the
- installation host or remotely accessible system.  If you do not already
- have a database server available, you should also install mysql-server.
+ installation host or a remotely accessible system.
  
--- cacti.old/debian/changelog	2012-01-01 10:28:46.039467059 +0100
+++ cacti/debian/changelog	2012-01-01 15:09:39.943121662 +0100
@@ -1,3 +1,11 @@
+cacti (0.8.7g-3) UNRELEASED; urgency=low
+
+  * Debconf templates and debian/control reviewed by the debian-l10n-
+    english team as part of the Smith review project. Closes: #653897
+  * [Debconf translation updates]
+
+ -- Christian Perrier <bubulle at debian.org>  Sun, 01 Jan 2012 15:09:39 +0100
+
 cacti (0.8.7g-2.1) unstable; urgency=low
 
   * Non-maintainer upload.
-------------- next part --------------
Source: cacti
Section: web
Priority: extra
Maintainer: Sean Finney <seanius at debian.org>
Build-Depends: debhelper (>= 5), po-debconf, quilt
Homepage: http://www.cacti.net/
Vcs-Browser: http://git.debian.org/?p=users/seanius/cacti.git
Vcs-Git: git://git.debian.org/git/users/seanius/cacti.git
Standards-Version: 3.9.1

Package: cacti
Architecture: all
Depends: apache2 | apache | apache-ssl | apache-perl | httpd, libapache2-mod-php5 | php5, php5-mysql, php5-cli, php5-snmp, virtual-mysql-client, rrdtool, snmp, libphp-adodb (>= 4.50-1), ucf, dbconfig-common (>= 1.8.8), ${misc:Depends}
Recommends: mysql-server, iputils-ping, logrotate
Suggests: php5-ldap
Description: web frontend for graphing systems and services monitoring data
 Cacti is a complete frontend to rrdtool. It stores all of the necessary
 information to create graphs and populates them with data in a MySQL
 database. It only uses PHP. Along with being able
 to maintain Graphs, Data Sources, and Round Robin Archives in a
 database, Cacti also handles data gathering. It also includes SNMP
 support for those used to creating traffic graphs with MRTG.
 .
 This package requires a functional MySQL database server on either the
 installation host or a remotely accessible system.
 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-cacti-maint/attachments/20120105/bc93d524/attachment.pgp>
