[Pkg-cacti-maint] Bug#815987: libphp-adodb requires porting to php7.0; mysql_pconnect is removed

[TheSin]

I agree using mysqli will fix it without change.

I just meant if mysql + php7 is used then you need to remove the persist on the dsn, according to the adodb code base that is what forces _pconnect with mysql driver, with mysqli persist is ignored.

I just wanted to put that info incase it was an easier option then trying to get everyone to update config to use mysqli.  I to am just using mysqli, but I wanted to figure out the why and how of it all.


> On Apr 4, 2016, at 12:37 PM, Paul Gevers <elbrus at debian.org> wrote:
> 
> Hi TheSin,
> 
> On 04-04-16 18:46, TheSin wrote:
>> I believe the real issue isn’t with adodb, it’s line 38 of /usr/share/cacti/site/lib/database.php
> 
> Without any change except for database_type, my testing was already
> successful. Do you have any idea when and how this code would be triggered?
> 
>> $dsn = "$db_type://" . rawurlencode($user) . ":" . rawurlencode($pass) . "@" . rawurlencode($host) . "/" . rawurlencode($db_name) . "?persist”;
>> 
>> I believe we must remove the persist, so it no longer uses _pconnect in adodb, and it’ll switch to using _connect instead.
>> 
>> This is untested though I plan to test it in a bit, but I believe this should fix it.
> 
> As said, switching from mysql to mysqli already fixed issues. Are you
> sure there is more that needs fixing?
> 
> Paul
> 
>