[Pkg-cacti-maint] Bug#889181: cacti changes for PHP7.2 and dep8 tests

[Nish Aravamudan]

Hi Paul,

On Feb 4, 2018 04:38, "Paul Gevers" <elbrus at debian.org> wrote:


Hi Nishanth,

Thanks for the report and the work with upstream to get this fixed.


On 03-02-18 07:25, Nishanth Aravamudan wrote:
> In Ubuntu, the attached patch was applied to achieve the following:
>
>   * debian/patches/php72_count_bc_changes.patch: PHP7.2 has deprecated
>     count() of non-Countable objects.
>   * debian/patches/update-cactisql.patch: Update cacti.sql for
>     readstring to community change.

I'll most likely just wait for the next upstream release, which I expect
to come soon (they release about every other week).


Sure, I was not aware of cacti's release schedule and we are moving to 7.2
for 18.04, so just wanted you to be aware. I will sync the update once I
see it from Debian.

> Note that even with this change, the DEP8 tests fail on Ubuntu 18.04,
> with:
>
> Unexpected output in /var/log/cacti/cacti.log:
> 02/02/2018 16:40:07 - AUTOM8 ERROR: The Network ID: 1 is disabled. You
must use the 'force' option to force it's execution.
>
> Which I think might be because we need to pass force to some URL or
> check a network enabled box in the script?

If I understood upstream correctly about this issue, we should just add
the line to the accepted output.


Yeah, that is what I will do in our delta, and then it should be part of
the sync if you make the same change.

-Nish


Paul
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-cacti-maint/attachments/20180204/e1c7793d/attachment.html>