[Pkg-cacti-maint] Bug#931702: cacti: Upgrading from Stretch (cacti 0.8.8h) to Buster (cacti 1.2.2) fails

[Bart Champagne]

Package: cacti
Version: 1.2.2+ds1-2
Severity: important
Tags: patch

Dear maintainer,

When upgrading from Stretch (cacti 0.8.8) to Buster (cacti 1.2.2) the upgrade of cacti fails after the intermediate upgrade to v1.1.34 due to a database upgrade failure.
This is documented in cacti Github bug #2482 (https://github.com/Cacti/cacti/issues/2482) where the fix is also referenced: https://github.com/Cacti/cacti/commit/be50141315b1c474cbca33e9ad26cacc0ef9c110

The fix: edit /usr/share/cacti/site/install/upgrades/1_1_34.php and apply the following patch:

@@ -244,7 +244,7 @@ function upgrade_to_1_1_34() {
	db_install_execute('ALTER TABLE `version`
		MODIFY COLUMN `cacti` char(20) NOT NULL DEFAULT ""');
-	db_install_execute('ALTER IGNORE TABLE version DROP PRIMARY KEY');
+	db_install_drop_key('version', 'key', 'PRIMARY');
	db_install_add_key('version', 'key', 'PRIMARY', array('cacti'), 'BTREE');
}


If the upgrade was already started, changing the upgrade script will not be enough and the upgrade must be started over.
Instructions to do that are documented in cacti bug #2561 (https://github.com/Cacti/cacti/issues/2561).
TL;DR: running "delete from settings where name like 'install_%';" on the cacti DB (and clearing the browser cache) restarts the upgrade.

It's probably opportune to fix the 1.1.34.php upgrade script in the 1.2.2 install package.

Kind regards,
Bart

-- System Information:
Debian Release: 10.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-5-amd64 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages cacti depends on:
ii  dbconfig-common                           2.0.11
ii  dbconfig-mysql                            2.0.11
ii  debconf [debconf-2.0]                     1.5.71
ii  fonts-dejavu-core                         2.37-1
ii  fonts-dejavu-extra                        2.37-1
ii  fonts-fork-awesome                        1.1.5+ds1-2
ii  javascript-common                         11
ii  libapache2-mod-php7.3 [libapache2-mod-ph  7.3.4-2
ii  libjs-c3                                  0.4.11+dfsg-2
ii  libjs-chart.js                            2.7.3+dfsg-5
ii  libjs-d3                                  3.5.17-2
ii  libjs-jquery                              3.3.1~dfsg-3
ii  libjs-jquery-colorpicker                  1.2.17-1
ii  libjs-jquery-cookie                       12-1.1
ii  libjs-jquery-hotkeys                      0~20130707+git2d51e3a9+dfsg-2
ii  libjs-jquery-jstree                       3.3.7+dfsg1-1
ii  libjs-jquery-metadata                     12-1.1
ii  libjs-jquery-tablesorter                  1:2.31.1+dfsg1-1
ii  libjs-jquery-timepicker                   1.2-1
ii  libjs-jquery-ui                           1.12.1+dfsg-5
ii  libjs-jquery-ui-theme-smoothness          1.12.1+dfsg-1
ii  libjs-jquery-ui-theme-south-street        1.12.1+dfsg-1
ii  libjs-jquery-ui-theme-ui-darkness         1.12.1+dfsg-1
ii  libjs-jquery-ui-touch-punch               0.0~git20141218.2.4bc0091+dfsg1-2
ii  libphp-phpmailer                          6.0.6-0.1
ii  perl                                      5.28.1-6
ii  php                                       2:7.3+69
ii  php-gd                                    2:7.3+69
ii  php-ldap                                  2:7.3+69
ii  php-mbstring                              2:7.3+69
ii  php-mysql                                 2:7.3+69
ii  php-php-gettext                           1.0.12-0.1
ii  php-phpseclib                             2.0.14-1
ii  php-snmp                                  2:7.3+69
ii  php-twig                                  2.6.2-2
ii  php-xml                                   2:7.3+69
ii  php7.3 [php]                              7.3.4-2
ii  php7.3-cli [php-cli]                      7.3.4-2
ii  php7.3-gd [php-gd]                        7.3.4-2
ii  php7.3-json [php-json]                    7.3.4-2
ii  php7.3-ldap [php-ldap]                    7.3.4-2
ii  php7.3-mbstring [php-mbstring]            7.3.4-2
ii  php7.3-snmp [php-snmp]                    7.3.4-2
ii  php7.3-xml [php-xml]                      7.3.4-2
ii  rrdtool                                   1.7.1-2
ii  snmp                                      5.7.3+dfsg-5
ii  ucf                                       3.0038+nmu1

Versions of packages cacti recommends:
ii  apache2 [httpd]                             2.4.38-3
ii  default-mysql-server                        1.0.5
ii  iputils-ping                                3:20180629-2
ii  logrotate                                   3.14.0-4
ii  mariadb-server-10.3 [virtual-mysql-server]  1:10.3.15-1
ii  php-gmp                                     2:7.3+69
ii  php7.3-gmp [php-gmp]                        7.3.4-2

Versions of packages cacti suggests:
pn  cacti-spine  <none>
pn  moreutils    <none>
pn  snmpd        <none>

-- debconf information excluded