[Pkg-cacti-maint] Bug#1043627: cacti-spine: Fails to build source after successful build

[Lucas Nussbaum]

Source: cacti-spine
Version: 1.2.24-1
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> ------------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package cacti-spine
> dpkg-buildpackage: info: source version 1.2.24-1
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Paul Gevers <elbrus at debian.org>
>  dpkg-source --before-build .
> dpkg-source: info: using options from cacti-spine-1.2.24/debian/source/options: --extend-diff-ignore=(^|/)(config\.guess|config\.sub|aclocal\.m4|configure|ltmain\.sh|Makefile\.in)$
>  debian/rules clean
> dh clean
>    dh_auto_clean
> 	make -j8 distclean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> rm -rf .libs _libs
> rm -f *.o
>  rm -f spine
> rm -f *.lo
> rm -f *.tab.c
> test -z "" || rm -f 
> rm -f config/config.h config/stamp-h1
> rm -f libtool config.lt
> rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
> test . = "." || test -z "" || rm -f 
> rm -f cscope.out cscope.in.out cscope.po.out cscope.files
> rm -f config.status config.cache config.log configure.lineno config.status.lineno
> rm -f ./.deps/error.Po
> rm -f ./.deps/keywords.Po
> rm -f ./.deps/locks.Po
> rm -f ./.deps/nft_popen.Po
> rm -f ./.deps/php.Po
> rm -f ./.deps/ping.Po
> rm -f ./.deps/poller.Po
> rm -f ./.deps/snmp.Po
> rm -f ./.deps/spine.Po
> rm -f ./.deps/sql.Po
> rm -f ./.deps/util.Po
> rm -f Makefile
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_autoreconf_clean
>    dh_clean
>  dpkg-source -b .
> dpkg-source: info: using options from cacti-spine-1.2.24/debian/source/options: --extend-diff-ignore=(^|/)(config\.guess|config\.sub|aclocal\.m4|configure|ltmain\.sh|Makefile\.in)$
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building cacti-spine using existing ./cacti-spine_1.2.24.orig.tar.gz
> dpkg-source: info: local changes detected, the modified files are:
>  cacti-spine-1.2.24/spine.1
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/cacti-spine_1.2.24-1.diff.3ErsdU
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/cacti-spine_1.2.24-1_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.