[Pkg-citadel-devel] Bug#475539: citadel: "apt-get install citadel-server" creates /etc/services (and possibly changes /etc/inittab)

[Andreas Jochens]

Package: citadel
Version: 7.33-4
Severity: normal
Tags: patch


Hello,

the citadel-server package creates /etc/services during postinst.

In a clean unstable buildd chroot I get the following:

# apt-get install citadel-server
[...]
# cat /etc/services
citadel         504/tcp

A subsequent "apt-get install netbase" leads to the following message:
[...]
Setting up netbase (4.32) ...

Configuration file `/etc/services'
 ==> File on system created by you or by a script.
 ==> File also in package provided by package maintainer.
   What would you like to do about it ?  Your options are:
    Y or I  : install the package maintainer's version
    N or O  : keep your currently-installed version
      D     : show the differences between the versions
      Z     : background this process to examine the situation
 The default action is to keep your current version.
*** services (Y/I/N/O/D/Z) [default=N] ? 


The /etc/services file is normally provided by the "netbase" package.

If the "netbase" package is installed first, the citadel-server package
will append a "citadel	504/tcp" line to /etc/services.

I do not think that "citadel-server" should create or change /etc/services 
during postinst.

The attached patch disables this and some other possibly unwanted things
(e.g. changes to /etc/inittab) in setup.c. 

If the citadel entry in /etc/services is really necessary 
it should probably be added to the etc-services template in the
"netbase" package.

Regards
Andreas Jochens

diff -urN ../tmp-orig/citadel-7.33/setup.c ./setup.c
--- ../tmp-orig/citadel-7.33/setup.c	2008-03-03 21:48:34.000000000 +0000
+++ ./setup.c	2008-04-11 07:18:21.000000000 +0000
@@ -1237,6 +1237,7 @@
 	unlink("citadel.log");
 	unlink("weekly");
 
+#if 0 /* disabled for debian */
 	check_services_entry();	/* Check /etc/services */
 #ifndef __CYGWIN__
 	delete_inittab_entry();	/* Remove obsolete /etc/inittab entry */
@@ -1264,6 +1265,7 @@
 	disable_other_mta("sendmail");
 	disable_other_mta("vmailmgrd");
 #endif
+#endif /* disabled for Debian
 
 	/* Check for the 'db' nss and offer to disable it */
 	fixnss();