[Pkg-citadel-devel] Bug#541071: citadel-webcit: Incorrect dependency in init.d LSB header

[Petter Reinholdtsen]

Package:  citadel-webcit
Version:  7.60-dfsg-1
Severity: important
Tags:     patch
User:     initscripts-ng-devel at lists.alioth.debian.org
Usertags: incorrect-dependency

With dependency based boot sequencing, I discovered what I believe is
a bug in the init.d/webcit script.  The server started uses syslog,
and should start after the syslog facility is available.  For this it
need to depend on $syslog.

<URL:http://refspecs.freestandards.org/LSB_2.1.0/LSB-generic/LSB-generic/initscrcomconv.html>
documents the LSB header format.  Some debian notes are available from
<URL:http://wiki.debian.org/LSBInitScripts>.

This patch should solve the issue.  Without it, the init.d script is
started too early and stopped to late.  I also improved the short
description, but did not know what to write for the long description
and left that one alone.

diff -ru webcit-7.60-dfsg/debian/webcit.init webcit-7.60-dfsg-pere/debian/webcit.init
--- webcit-7.60-dfsg/debian/webcit.init 2009-08-11 15:51:13.000000000 +0200
+++ webcit-7.60-dfsg-pere/debian/webcit.init    2009-08-11 15:53:22.427528000 +0200
@@ -1,11 +1,11 @@
 #! /bin/sh
 ### BEGIN INIT INFO
 # Provides:          webcit
-# Required-Start:    $local_fs $remote_fs
-# Required-Stop:     $local_fs $remote_fs
+# Required-Start:    $local_fs $remote_fs $syslog
+# Required-Stop:     $local_fs $remote_fs $syslog
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6
-# Short-Description: Example initscript
+# Short-Description: Start the webcit citadel service
 # Description:       This file should be used to construct scripts to be
 #                    placed in /etc/init.d.
 ### END INIT INFO

Happy hacking,
--
Petter Reinholdtsen