[Pkg-citadel-devel] Bug#541075: citadel-server: Incorrect dependency in init.d LSB header

[Petter Reinholdtsen]

Package:  citadel-server
Version:  7.60-1
Severity: important
Tags:     patch
User:     initscripts-ng-devel at lists.alioth.debian.org
Usertags: incorrect-dependency

With dependency based boot sequencing, I discovered what I believe is
a bug in the init.d/citadel script.  The server started uses syslog,
and should start after the syslog facility is available.  For this it
need to depend on $syslog.

<URL:http://refspecs.freestandards.org/LSB_2.1.0/LSB-generic/LSB-generic/initscrcomconv.html>
documents the LSB header format.  Some debian notes are available from
<URL:http://wiki.debian.org/LSBInitScripts>.

This patch should solve the issue.  Without it, the init.d script is
started too early and stopped to late.

diff -ur citadel-7.60/debian/citadel.init citadel-7.60-pere/debian/citadel.init
--- citadel-7.60/debian/citadel.init    2009-08-11 15:49:29.000000000 +0200
+++ citadel-7.60-pere/debian/citadel.init       2009-08-11 15:46:48.465317000 +0200
@@ -1,8 +1,8 @@
 #!/bin/sh
 ### BEGIN INIT INFO
 # Provides:          citadel
-# Required-Start:    $local_fs $remote_fs
-# Required-Stop:     $local_fs $remote_fs
+# Required-Start:    $local_fs $remote_fs $syslog
+# Required-Stop:     $local_fs $remote_fs $syslog
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6
 # Short-Description: control citadel server start at boot time

Happy hacking,
--
Petter Reinholdtsen