[Pkg-citadel-devel] Bug#846543: citadel: FTBFS (dereferencing pointer to incomplete type)

[Santiago Vila]

Package: src:citadel
Version: 902-2
Severity: serious

Dear maintainer:

I tried to build this package in stretch with "dpkg-buildpackage -A"
(which is what the "Arch: all" autobuilder would do to build it)
but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
dh build-indep --with autotools-dev,quilt
   dh_testdir -i
   dh_update_autotools_config -i
   dh_autotools-dev_updateconfig -i
   dh_quilt_patch -i
Applying patch icalerror_errors_are_fatal.patch
patching file modules/calendar/serv_calendar.c
Hunk #1 succeeded at 2580 (offset -6 lines).

Applying patch clean.patch
patching file Makefile.in


[... snipped ...]

modules/calendar/serv_calendar.c:2160:59: warning: passing argument 1 of 'icaltimezone_get_component' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   zc = icalcomponent_new_clone(icaltimezone_get_component(attached_zones[i]));
                                                           ^~~~~~~~~~~~~~
In file included from modules/calendar/serv_calendar.c:21:0:
/usr/include/libical/ical.h:2775:36: note: expected 'icaltimezone * {aka struct _icaltimezone *}' but argument is of type 'const icaltimezone * {aka const struct _icaltimezone *}'
 LIBICAL_ICAL_EXPORT icalcomponent *icaltimezone_get_component(icaltimezone *zone);
                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~
CC modules/checkpoint/serv_checkpoint.c
CC modules/clamav/serv_virus.c
CC modules/crypto/serv_crypto.c
modules/crypto/serv_crypto.c: In function 'init_ssl':
modules/crypto/serv_crypto.c:87:3: warning: implicit declaration of function 'RAND_egd' [-Wimplicit-function-declaration]
   RAND_egd(EGD_POOL);
   ^~~~~~~~
modules/crypto/serv_crypto.c:147:22: error: dereferencing pointer to incomplete type 'DH {aka struct dh_st}'
  if (!(BN_hex2bn(&(dh->p), DH_P))) {
                      ^~
modules/crypto/serv_crypto.c:173:3: warning: 'RSA_generate_key' is deprecated [-Wdeprecated-declarations]
   rsa = RSA_generate_key(1024, /* modulus size */
   ^~~
In file included from /usr/include/openssl/rsa.h:13:0,
                 from /usr/include/openssl/x509.h:31,
                 from /usr/include/openssl/ssl.h:50,
                 from modules/crypto/serv_crypto.c:20:
/usr/include/openssl/rsa.h:193:1: note: declared here
 DEPRECATEDIN_0_9_8(RSA *RSA_generate_key(int bits, unsigned long e, void
 ^
modules/crypto/serv_crypto.c:305:35: error: dereferencing pointer to incomplete type 'X509_REQ {aka struct X509_req_st}'
      X509_set_issuer_name(cer, req->req_info->subject);
                                   ^~
In file included from /usr/include/openssl/ssl.h:48:0,
                 from modules/crypto/serv_crypto.c:20:
modules/crypto/serv_crypto.c: In function 'CtdlStartTLS':
modules/crypto/serv_crypto.c:637:23: error: dereferencing pointer to incomplete type 'SSL {aka struct ssl_st}'
  BIO_set_close(CC->ssl->rbio, BIO_NOCLOSE);
                       ^
At top level:
modules/crypto/serv_crypto.c:61:22: warning: 'id_callback' defined but not used [-Wunused-function]
 static unsigned long id_callback(void)
                      ^~~~~~~~~~~
Makefile:145: recipe for target 'modules/crypto/serv_crypto.o' failed
make[1]: *** [modules/crypto/serv_crypto.o] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: make -j1 returned exit code 2
debian/rules:105: recipe for target 'build-indep' failed
make: *** [build-indep] Error 2
dpkg-buildpackage: error: debian/rules build-indep gave error exit status 2
--------------------------------------------------------------------------------

If you need a full build log, just say so, but this should be easy to reproduce,
as the failure also happens here:

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/citadel.html

While we are at it: Please consider uploading in source-only form, so that
we get official build logs available here even for Arch:all architecture:

https://buildd.debian.org/status/package.php?p=citadel

Thanks.