[Pkg-clamav-devel] Lintian override (Was: Re: repo set up)

[Stephen Gran]

This one time, at band camp, Michael Meskes said:
> On Tue, Sep 09, 2008 at 08:12:04PM +0100, Stephen Gran wrote:
> > This one time, at band camp, Michael Tautschnig said:
> > > After reading the above pieces of code I wonder what the added value of setting
> > > TemporaryDirectory to /tmp is at all? Apparently, that would be the default
> > > anyway? 
> > 
> > There really isn't any, except ease of making ucf do sensible things.
> > At some point, I made the decision to have all possible config file
> > entries handled by the maintainer scripts - in for a penny, in for a
> > pound, and all that.  So the scripts currently set quite a lot to their
> > default values, and could just as well be left out.
> 
> I finally got around fixing this. I removed setting of TemporaryDirectory and
> replaced it with a comment. There appears to be another prolem when using this,
> namely that it disables overriding the temporary directory with some
> environment variable.

--- a/debian/clamav-base.postinst.in
+++ b/debian/clamav-base.postinst.in
@@ -202,7 +202,6 @@ case "$1" in
     [ -z "$LogFileMaxSize" ] && LogFileMaxSize=0
     [ -z "$LogClean" ] && LogClean=false
     [ -z "$LogVerbose" ] && LogVerbose=false
-    [ -z "$TemporaryDirectory" ] && TemporaryDirectory='/tmp'
     [ -z "$selfcheck" ] && selfcheck=1800
     [ -z "$Foreground" ] && Foreground=false
     [ -z "$Debug" ] && Debug=false
@@ -241,6 +240,8 @@ case "$1" in
     [ -z "$StructuredDataDetection" ] && StructuredDataDetection=false
 
     cat >> $DEBCONFFILE << EOF
+# TemporaryDirectory is no set to its default /tmp here to make overriding
+# the default with environment variables TMPDIR/TMP/TEMP possible
 User $user
 AllowSupplementaryGroups $AllowSupplementaryGroups
 ScanMail $scanmail
@@ -260,7 +261,6 @@ LogClean $LogClean
 LogVerbose $LogVerbose
 PidFile $PidFile
 DatabaseDirectory $DatabaseDirectory
-TemporaryDirectory $TemporaryDirectory
 SelfCheck $selfcheck
 Foreground $Foreground
 Debug $Debug

This will result in someone with an altered TemporaryDirectory option
getting lost on upgrade without manual work, unless I'm missing
something.
-- 
 -----------------------------------------------------------------
|   ,''`.                                            Stephen Gran |
|  : :' :                                        sgran at debian.org |
|  `. `'                        Debian user, admin, and developer |
|    `-                                     http://www.debian.org |
 -----------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-clamav-devel/attachments/20080917/1ad66683/attachment.pgp