[Pkg-clamav-devel] Request for review of new debconf questions (clamav)

[Stephen Gran]

Hi Christian!

This one time, at band camp, Christian Perrier said:
> If you agree with this version (please check it....this is based on
> the templates file we discussed about, 10 days ago....I haven't
> checked whether you actually added tempaltes), I propose sending the
> call for translations myself, just as I do when we conduct a full
> review.

As always, thank you very much for your thorough review.  Some comments
in line below.

> Template: clamav-milter/debconf

Looks great.

> Template: clamav-milter/FixStaleSocket

Looks great.

> Template: clamav-milter/User
> Type: string
> Default: clamav
> _Description: User to run clamav-milter as:
>  It is recommended to run the ClamAV programs as a non-privileged user.
>  This will work with most MTAs with a little tweaking. However, using
>  clamd for file system scans will require running clamav-milter as root.
>  .
>  Please see README.Debian in the clamav-base package for details.

The bit about filesystem scans makes no sense for the milter - I think
this language was copied directly from the template for clamav-daemon,
where it does make some sense.  I think we should just drop the sentence
beginning with "However".

> Template: clamav-milter/AddGroups

Looks great.

> Template: clamav-milter/ReadTimeout

Looks great.

> Template: clamav-milter/Foreground
> Type: boolean
> Default: false
> _Description: Should clamav-milter stay in foreground (not forking)?

Setting this option is only useful for debugging and is actively harmful
(it will prevent the init script from returning at system boot time,
potentially breaking bootup).  We should drop this option altogether.
Admins can still add it for debugging purposes manually.  If we want to
support running clamav-milter from a supervisor (as we do for
clamav-daemon and so on), then we should change the template to be clear
that that is what we're talking about.

> Template: clamav-milter/Chroot

Looks great.

> Template: clamav-milter/PidFile

Looks great.

> Template: clamav-milter/TemporaryDirectory

Looks great.

> Template: clamav-milter/ClamdSocket
> Type: string
> Default: unix:/var/run/clamav/clamd.ctl

My only comment here is that I'd like the default to be pulled from
clamav-daemon, if possible.  I don't think this affects the templates at
all, just the code, but I wanted to double check with you.

> Template: clamav-milter/LocalNet

Looks great.

> Template: clamav-milter/Whitelist

Looks great.

> Template: clamav-milter/OnClean
<...>
>  This setting is meant for testing purposes only.

Since this is just for testing, I don't think it's useful to offer a
debconf template for it.  Let's just drop it altogether.

> Template: clamav-milter/OnInfected

Looks great.

> Template: clamav-milter/OnFail

Looks great.

> Template: clamav-milter/RejectMsg

Looks great.

> Template: clamav-milter/AddHeader

Looks great.

> Template: clamav-milter/LogFile

Looks great.

> Template: clamav-milter/LogFileUnlock

Looks great.

> Template: clamav-milter/LogFileMaxSize

Looks great.

> Template: clamav-milter/LogTime

Looks great.

> Template: clamav-milter/LogSyslog

Looks great.

> Template: clamav-milter/LogFacility

Looks great.

> Template: clamav-milter/LogVerbose

Looks great.

> Template: clamav-milter/LogInfected

Looks great.

> Template: clamav-milter/MaxFileSize

Looks great.

Thanks again,
-- 
 -----------------------------------------------------------------
|   ,''`.                                            Stephen Gran |
|  : :' :                                        sgran at debian.org |
|  `. `'                        Debian user, admin, and developer |
|    `-                                     http://www.debian.org |
 -----------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-clamav-devel/attachments/20090404/6467ebb3/attachment.pgp