[Pkg-clamav-devel] Bug#546450: clamav-daemon: Incorrect runlevels and dependencies in init.d script

[Petter Reinholdtsen]

Package:  clamav-daemon
Version:  0.88.4-3
Severity: important
Tags:     patch
User:     initscripts-ng-devel at lists.alioth.debian.org
Usertags: incorrect-runlevels incorrect-dependency

With dependency based boot sequencing, I discovered what I believe is
a bug in the init.d script.  The header do not list runlevel 1 as a
stop runlevel.  This will make switches from runlevel 1 to 2-5 fail to
restart the daemon.  Also, the scripts uses files in /usr/ and should
depend on $remote_fs, and I believe a stop dependency on $syslog
should be used to make sure the syslog messages sent during shutdown
are recorded.  The empty should- headers can be removed, but I kept
them for symmetry. :)

<URL: http://refspecs.freestandards.org/LSB_2.1.0/LSB-generic/LSB-generic/initscrcomconv.html >
documents the LSB header format.  Some debian notes are available from
<URL: http://wiki.debian.org/LSBInitScripts >.

This patch should solve the issue.  Without it, the package will fail
to install the stop symlink in rc1.d.

diff -ur clamav-0.95.2+dfsg/debian/clamav-daemon.init.in clamav-0.95.2+dfsg-pere/debian/clamav-daemon.init.in
--- clamav-0.95.2+dfsg/debian/clamav-daemon.init.in     2009-09-13 11:47:37.000000000 +0200
+++ clamav-0.95.2+dfsg-pere/debian/clamav-daemon.init.in        2009-09-13 11:48:50.000000000 +0200
@@ -7,12 +7,10 @@
 #
 ### BEGIN INIT INFO
 # Provides:          clamav-daemon
-# Required-Start:    $syslog
-# Should-Start:
-# Required-Stop:
-# Should-Stop:
+# Required-Start:    $remote_fs $syslog
+# Required-Stop:     $remote_fs $syslog
 # Default-Start:     2 3 4 5
-# Default-Stop:      0 6
+# Default-Stop:      0 1 6
 # Short-Description: ClamAV daemon
 # Description:       Clam AntiVirus userspace daemon
 ### END INIT INFO
diff -ur clamav-0.95.2+dfsg/debian/clamav-freshclam.init.in clamav-0.95.2+dfsg-pere/debian/clamav-freshclam.init.in
--- clamav-0.95.2+dfsg/debian/clamav-freshclam.init.in  2009-09-13 11:47:37.000000000 +0200
+++ clamav-0.95.2+dfsg-pere/debian/clamav-freshclam.init.in     2009-09-13 11:49:15.000000000 +0200
@@ -2,12 +2,12 @@

 ### BEGIN INIT INFO
 # Provides:          clamav-freshclam
-# Required-Start:    $syslog
+# Required-Start:    $remote_fs $syslog
+# Required-Stop:     $remote_fs $syslog
 # Should-Start:      clamav-daemon
-# Required-Stop:
 # Should-Stop:
 # Default-Start:     2 3 4 5
-# Default-Stop:      0 6
+# Default-Stop:      0 1 6
 # Short-Description: ClamAV virus database updater
 # Description:       Clam AntiVirus virus database updater
 ### END INIT INFO
diff -ur clamav-0.95.2+dfsg/debian/clamav-milter.init.in clamav-0.95.2+dfsg-pere/debian/clamav-milter.init.in
--- clamav-0.95.2+dfsg/debian/clamav-milter.init.in     2009-09-13 11:47:37.000000000 +0200
+++ clamav-0.95.2+dfsg-pere/debian/clamav-milter.init.in        2009-09-13 11:49:34.000000000 +0200
@@ -1,12 +1,12 @@
 #!/bin/sh
 ### BEGIN INIT INFO
 # Provides:          clamav-milter
-# Required-Start:    $syslog
+# Required-Start:    $remote_fs $syslog
+# Required-Stop:     $remote_fs $syslog
 # Should-Start:      clamav-daemon
-# Required-Stop:
 # Should-Stop:
 # Default-Start:     2 3 4 5
-# Default-Stop:      0 6
+# Default-Stop:      0 1 6
 # Short-Description: ClamAV virus milter
 # Description:       Clam AntiVirus milter interface
 ### END INIT INFO

Happy hacking,
-- 
Petter Reinholdtsen