[Pkg-clamav-devel] Bug#732744: Bug#732744: clamav: use dh-autoreconf for better new-port coverage

[Dimitri John Ledkov]

On 22 December 2013 10:34, Stephen Gran <sgran at debian.org> wrote:
> This one time, at band camp, Dimitri John Ledkov said:
>> Hi,
>>
>> The ppc64el port requires a patch to libtool.m4. I don't think that's in
>> Debian yet, but when it is it will require autoreconfing a bunch of
>> packages to pick it up. clamav could handle this quite easily by using
>> dh-autoreconf, when libtool is in use (as of course it is here),
>> dh-autoreconf is a superset of autotools-dev, and it seems to still
>> build just fine if I do the following.  I did have to do a bit of extra
>> work to make things happy with new automake.
>>
>>   * Convert to dh-autoreconf in order to update libtool.m4 for new
>>     ports.
>>   * Remove -Werror from automake flags, to avoid failing autoreconf with
>>     new automake.
>
> Removing -Werror is not a decision to be taken quite so lightly.  What
> fails and why can't that be fixed instead?

automake1.14 emits many new warnings, about potential future changes
in automake2.0. No actual behaviour has changed in automake1.14, nor
will change in automake1.x series under the new versioning scheme.
Therefore the same reasoning to use -Werror, no longer applies with
changed automake versioning schemes.

Warnings emitted are:
* subdir-objects not enabled, yet will be default in automake2.0. Yet
automake1.x will not enable it by default, so no reason to change that
in the distro at this time (and especially in what appears to be
included copies of llvm source code).
* AM_PROG_AR required when linking libraries using a non-POSIX
archiver, yet Debian uses a POSIX archiver.

My patch doesn't hide any of those warnings, they are still printed in
the buildlog, but fixing those warnings is not applicable in Debian to
this package at this time.

Of course, as a maintainer, you may choose to fix/patch those
warnings. I don't think it is appropriate, and therefore didn't make
those changes in my proposed patch.

The only requirements in this bug report for arm64/ppc64el
compatibility are: config.guess/sub + libtool need updating at build
time to make this package compatible with those architectures, when
they will be added to debian. So one could even achieve that without
using dh_autoreconf or executing automake. But I usually prefer to use
dh_autoreconf to perform such changes at build time.

-- 
Regards,

Dimitri.