[Pkg-clamav-devel] Redo of the initscripts

[Andreas Cadhalpun]

Hi Sebastian,

On 09.04.2014 12:56, Sebastian Andrzej Siewior wrote:
> I think I completed the re-do of the init scripts for freshclam, clamd
> and milter. I did my last tests yesterday.
> The primary motivation was to close #580188. The use a PID file is now
> required. start-stop-daemon uses it now to kill the proper daemon. I
> also use "pkill -0" to check if the daemon is running.
> The change in clamav where I add the extra \n to the pidfile is in
> upstream's bugilla as #10907 and should be part of 0.98.2.

Thanks for modernizing the init scripts. (The old method of stopping the 
service was really ugly.)

> The whole thing is in the bigeasy_init branch. Could someone please take
> a look at it before it gets into unstable?

I reviewed the new init files and they look good. I just removed some 
now unused code.

One thing I noticed is that your patch is not integrated via git-dpm as 
the other patches are and also duplicates the number 0001.
I think the best way to fix this is to revert your commit adding the 
patch, then use 'git-dpm checkout-patched', commit your fixes to the 
upstream sources and finally use 'git-dpm update-patches'.

Otherwise this can be merged to unstable.

Best regards,
Andreas