[Pkg-clamav-devel] Processing of clamav_0.98.4+dfsg-1_i386.changes

[Andreas Cadhalpun]

Hi,

On 17.06.2014 03:55, Scott Kitterman wrote:
> On Tuesday, June 17, 2014 01:51:57 Debian FTP Masters wrote:
>> clamav_0.98.4+dfsg-1_i386.changes uploaded successfully to localhost
> ...

Finally released! :)
I'm still wondering, why it took so long...

> Updated in git too.  Feel free to review and fix what I screwed up.

It seems you didn't push the upstream-unstable and pristien-tar branches.
Did you intentionally re-include the libclamav/c++/llvm directory?
Additionally libclamunrar_iface/Makefile.am is missing from EXTRA_DIST 
in Makefile.am and Makefile.in. Why?

> We have accumulated a few patches that I'd like to see if we can push
> upstream.

0001-Change-paths-in-sample-conf-file-to-match-Debian.patch:
This is entirely Debian specific.

0002-Fix-STAT64-definition-and-add-missing-includes.patch
To me it seems that this STAT64 definition is entirely windows specific, 
so it should be '#ifdef _WIN32' and not the current approach with a 
blacklist.
If it actually works on some linux/UNIX distributions, this is probably 
not wanted upstream.
Anyway the additional includes seem to be superfluous, as they are never 
included, because they are inside the STAT64_BLACKLIST block.

0003-Add-an-additional-n-after-the-number-in-the-pidfile.patch
Already forwarded: #10907

0004-unit_tests-increment-test-timeout-from-40secs-to-5mi.patch
This seems not to help, as it timed out again on mipsel and sparc. We 
should probably drop this patch.

0005-Fix-FTBFS-with-LLVM-3.1-3.4.patch
Already forwarded: #10981

0006-enable-llvm-jit-on-kfreebsd.patch
I think kfreebsd is Debian-specific, but it wouldn't hurt if upstream 
applied this.

0007-Fix-underlinking-with-llvm-in-libclamav-c-Makefile.a.patch
Also forwarded to: #10981

0008-bb-11028-fixed-a-deadlock-issue-with-fanotify-and-lo.patch
This comes from upstream: #11028

>  Is anyone available Friday to discuss it with them on IRC?

It depends on the time, but probably yes.

Best regards,
Andreas